Date: Thu, 30 Sep 2010 11:44:36 +0000 From: Bernhard Froehlich <decke@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Pav Lucistnik <pav@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/zfsnap Makefile distinfo Message-ID: <6d5fc03b56f03828baca44f21e4dd04f@bluelife.at> In-Reply-To: <20100930021101.26c36286.stas@FreeBSD.org> References: <201009291312.o8TDCTwo029078@repoman.freebsd.org> <20100929165421.70c8064a.stas@FreeBSD.org> <4CA4505F.1080306@FreeBSD.org> <20100930021101.26c36286.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 30 Sep 2010 02:11:01 -0700, Stanislav Sedov <stas@FreeBSD.org> wrote: > On Thu, 30 Sep 2010 10:54:55 +0200 > Pav Lucistnik <pav@FreeBSD.org> mentioned: > >> > >> > It's usually beneficial if you also provide the short changelog of changes >> > in the software, or at least a link to the changelog. Especially in this >> > case, when maintainer wrote it clearly in the PR. >> >> It's not an usual practice. >> > > Unfortunately. But it's a good one to follow, and we used to do this some > time ago. In this special case it could be beneficial because the submitter is also the author of the project and I couldn't find the changelog anywhere after a short search. Sorry for that. >> Again, it's not a usual practice to have this in the Makefiles so the >> cleanup is understandable. > > I understand the cleanup reason, and actually all hands for this, but > the change should be mentioned in the commit message. Okay, I will also mention such tiny changes in the future. -- Bernhard Froehlich http://www.bluelife.at/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6d5fc03b56f03828baca44f21e4dd04f>