Date: Tue, 23 Jun 2015 02:56:10 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Andrew Gallatin <gallatin@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-stable@freebsd.org" <svn-src-stable@freebsd.org>, "svn-src-stable-10@freebsd.org" <svn-src-stable-10@freebsd.org> Subject: Re: svn commit: r284706 - stable/10/sys/dev/ixl Message-ID: <31922418-6DDC-4AA5-BF92-5E1C9075D00F@FreeBSD.org> In-Reply-To: <201506221937.t5MJb5wt059430@svn.freebsd.org> References: <201506221937.t5MJb5wt059430@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I think you have to use if_initbaudrate() in 10 (maybe 9 as well?) instead o= f a direct assignment since if_baudrate is only a long (and thus 32-bit on 3= 2-bit platforms). We use an extra scaling variable in older branches to all= ow higher baud rates to be represented. --=20 John Baldwin > On Jun 22, 2015, at 15:37, Andrew Gallatin <gallatin@FreeBSD.org> wrote: >=20 > Author: gallatin > Date: Mon Jun 22 19:37:04 2015 > New Revision: 284706 > URL: https://svnweb.freebsd.org/changeset/base/284706 >=20 > Log: > MFC r284612: Fix a typo >=20 > Sponsored by: Netflix >=20 > Modified: > stable/10/sys/dev/ixl/if_ixl.c > Directory Properties: > stable/10/ (props changed) >=20 > Modified: stable/10/sys/dev/ixl/if_ixl.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- stable/10/sys/dev/ixl/if_ixl.c Mon Jun 22 19:01:09 2015 (r284705= ) > +++ stable/10/sys/dev/ixl/if_ixl.c Mon Jun 22 19:37:04 2015 (r284706= ) > @@ -2324,7 +2324,7 @@ ixl_setup_interface(device_t dev, struct > } > if_initname(ifp, device_get_name(dev), device_get_unit(dev)); > ifp->if_mtu =3D ETHERMTU; > - ifp->if_baudrate =3D 4000000000; // ?? > + ifp->if_baudrate =3D IF_Gbps(40); > ifp->if_init =3D ixl_init; > ifp->if_softc =3D vsi; > ifp->if_flags =3D IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST; >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?31922418-6DDC-4AA5-BF92-5E1C9075D00F>