Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 May 2016 12:05:25 +0200
From:      John Marino <freebsd.contact@marino.st>
To:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r415493 - in head/games/libretro-cores: . files
Message-ID:  <307385ca-1cd1-83ae-1a66-b2a7210b5054@marino.st>
In-Reply-To: <201605190700.u4J70sfs011294@repo.freebsd.org>
References:  <201605190700.u4J70sfs011294@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 5/19/2016 9:00 AM, Mathieu Arnold wrote:
> Author: mat
> Date: Thu May 19 07:00:54 2016
> New Revision: 415493
> URL: https://svnweb.freebsd.org/changeset/ports/415493
>
> Log:
>   Remove the use of :@, it must not be used before 9 goes out of support.
>
>   Incidentally, simplify quite a bit, and fix build on 9.
>
>   Sponsored by:	Absolight
>
> [snip]
> Modified: head/games/libretro-cores/Makefile
> ==============================================================================
> --- head/games/libretro-cores/Makefile	Thu May 19 06:28:48 2016	(r415492)
> +++ head/games/libretro-cores/Makefile	Thu May 19 07:00:54 2016	(r415493)
> [snip]
>
>  do-build:
>  	@for dir in ${CORE_DIRS}; do \
> -	  ${ECHO_MSG} "===>  Building for ${PKGNAME}: core $${dir} (`date`)"; \
> -	  if [ -f ${WRKSRC}/$${dir}/Makefile.freebsd ]; then \
> -	    (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD} ${MAKE_FLAGS} Makefile.freebsd ${_MAKE_JOBS} ${MAKE_ARGS}); \
> -	  elif [ -f ${WRKSRC}/$${dir}/Makefile.libretro ]; then \
> -	    (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD} ${MAKE_FLAGS} Makefile.libretro ${_MAKE_JOBS} ${MAKE_ARGS}); \
> +	  ${ECHO_MSG} "===>  Building for ${PKGNAME}: core ${dir} ($$(date))"; \
> +	  cd ${WRKSRC}/${dir}; \

We think this is a mistake:
changing "cd ${WRKSRC}/$${dir};" to "cd ${WRKSRC}/${dir};"
("core $${dir}" => "core ${dir}" is wrong too but that's only an echo issue)

I'm wondering how this is working on FreeBSD actually ...

John



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?307385ca-1cd1-83ae-1a66-b2a7210b5054>