Date: Wed, 18 Aug 2004 13:56:14 -0700 From: Julian Elischer <julian@elischer.org> To: Julian Elischer <julian@elischer.org> Cc: John Polstra <jdp@polstra.com> Subject: Re: netgraph only on i386/ia64 - why ? Message-ID: <4123C26E.8040901@elischer.org> In-Reply-To: <4123A2B2.2040209@elischer.org> References: <XFMail.20040818112451.jdp@polstra.com> <4123A2B2.2040209@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote: > John Polstra wrote: > >> On 18-Aug-2004 Julian Elischer wrote: >> >>> John Polstra wrote: >>> >>>> There is one problem with netgraph on 64-bit platforms. The ng_msghdr >>>> struct is 52 bytes / 4-byte aligned (see ng_message.h). That means >>>> the message payload is not well-aligned for 64-bit platforms. It >>>> would be nice to fix that (and bump NG_VERSION, of course). Nobody >>>> ever guaranteed that the message payload would be aligned, but it >>>> makes things a lot more convenient. >>> >>> >>> if we do this we should do it now so that we have a consistent ABI >>> from 5.3 on.. >>> >>> scott (et al), should we pad an extra 4 bytes in this now? >>> it's low/no risk, but better now than after 5.3 has been released.. re: I'll do the commit to -current today.. what other files should I change..? UPDATING (user utilitiesw will need recompile) and I guess the 50xxxx number.. (where is that number again?) anything else?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4123C26E.8040901>