Date: Thu, 15 Jan 2009 09:54:10 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: "Maksim Yevmenkin" <maksim.yevmenkin@gmail.com> Cc: "freebsd-bluetooth@freebsd.org" <freebsd-bluetooth@freebsd.org>, Alfred Perlstein <alfred@freebsd.org> Subject: Re: USB2: ng_ubt2 patch Message-ID: <200901150954.11454.hselasky@c2i.net> In-Reply-To: <bb4a86c70901141705s1af508e3yf79383ecf97293cf@mail.gmail.com> References: <bb4a86c70901141705s1af508e3yf79383ecf97293cf@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 15 January 2009, Maksim Yevmenkin wrote: > dear bluetooth users, > > please find attached patch for ng_ubt2 (well it is almost a complete > rewrite). > > this is an early preview and likely to have bugs. i briefly kicked the > tires to make sure it compiles and did some very quick testing, i.e. > run few hci commands, sdp transfers etc. > > this is my first attempt to write something under usb2, so any > review/comments/suggestions/etc. are greatly appreciated. > > thanks, > max Hi, This looks very interesting. 1) Maybe you just want to merge together all the USB config structures into one? 2) There are some isochronous details for non-Full speed USB. UBT_ISOC_NFRAMES must be a factor of 8 if it should work. How much bluetooth functionality have you tested? BTW: I think your patch is pretty Ok. Is what you attached the final version of your patch? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901150954.11454.hselasky>