Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Feb 2009 10:04:59 +0000 (UTC)
From:      Scott Long <scottl@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r188570 - head/sys/cam
Message-ID:  <200902131004.n1DA4xol082999@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: scottl
Date: Fri Feb 13 10:04:59 2009
New Revision: 188570
URL: http://svn.freebsd.org/changeset/base/188570

Log:
  In the case that the probe has determined that it can't query the device for
  a serial number, fall through to the next case so that initial negotiation
  still happens.  Without this, devices were showing up with only 1 available
  tag opening, leading to observations of very poor I/O performance.
  
  This should fix problems reported with VMWare Fusion and ESX.  Early
  generation MPT-SAS controllers with SATA disks might also be affected.
  HP CISS controllers are also likely affected, as are many other
  pseudo-scsi disk subsystems.

Modified:
  head/sys/cam/cam_xpt.c

Modified: head/sys/cam/cam_xpt.c
==============================================================================
--- head/sys/cam/cam_xpt.c	Fri Feb 13 06:17:53 2009	(r188569)
+++ head/sys/cam/cam_xpt.c	Fri Feb 13 10:04:59 2009	(r188570)
@@ -6143,10 +6143,9 @@ probedone(struct cam_periph *periph, uni
 			xpt_schedule(periph, priority);
 			return;
 		}
-		xpt_release_ccb(done_ccb);
-		softc->action = PROBE_TUR_FOR_NEGOTIATION;
-		xpt_schedule(periph, priority);
-		return;
+
+		csio->data_ptr = NULL;
+		/* FALLTHROUGH */
 	}
 
 	case PROBE_SERIAL_NUM_1:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902131004.n1DA4xol082999>