Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Dec 2015 22:32:24 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 205424] i386/boot: use macros from <machine/psl.h> to represent eflags's bits
Message-ID:  <bug-205424-8-khUGVmaL2c@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-205424-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-205424-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205424

John Baldwin <jhb@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|freebsd-bugs@FreeBSD.org    |jhb@FreeBSD.org
             Status|New                         |In Progress

--- Comment #1 from John Baldwin <jhb@FreeBSD.org> ---
The patch appears to have a lot of unrelated whitespace diffs.  Most of the
i386 boot code already uses PSL_* constants via the nested include of
<machine/psl.h> in btxv86.h.  In general the boot code uses V86_CY() to check
the carry flag and it looks like a few places just weren't updated to use that.

I've uploaded a change that I think fixes all the stragglers.  I haven't built
it yet to test though.

https://github.com/bsdjhb/freebsd/compare/boot_i386_eflags.diff

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-205424-8-khUGVmaL2c>