Date: Fri, 15 Apr 2016 12:00:24 +0000 From: "jtl (Jonathan T. Looney)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Requested Changes To] D5872: tcp: Don't prematurely drop receiving-only connections Message-ID: <35a14b87d2d7829600f8081128199c1e@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org> References: <differential-rev-PHID-DREV-5vu7wrfibtoing77xfvt-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
jtl requested changes to this revision. jtl added a reviewer: jtl. jtl added a comment. This revision now requires changes to proceed. Doesn't tp->t_rxtshift get updated on a successful send? If not, I think that is what we should be fixing. Personally, I think a connection should drop if we aren't able to send any ACKs for 350 seconds. INLINE COMMENTS sys/netinet/tcp_output.c:1561 You already own a lock on tp. No need to do atomic operations. REVISION DETAIL https://reviews.freebsd.org/D5872 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, glebius, hiren, lstewart, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, freebsd-net-list, transport, jtl Cc: jtl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35a14b87d2d7829600f8081128199c1e>