Date: 22 Jan 2001 23:54:29 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: Bruce Evans <bde@zeta.org.au> Cc: arch@FreeBSD.ORG Subject: Re: Second zone allocator patch Message-ID: <xzpk87ngpui.fsf@flood.ping.uio.no> In-Reply-To: Bruce Evans's message of "Mon, 22 Jan 2001 19:26:55 %2B1100 (EST)" References: <Pine.BSF.4.21.0101221903190.27567-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans <bde@zeta.org.au> writes: > The simplelock was a spinlock, so changing it to a lock that can sleep > changes the semantics. This seems to be a bug in the ZONE_INTERRUPT > case -- note how the ZONE_INTERRUPT case of _zget() avoids locking > stuff while the !ZONE_INTERRUPT case uses it. OK - how about changing the init code so that if the ZONE_INTERRUPT flag is specified, the lock is initialized as a spin lock? That will require adding a "zmtxtype" or similar member to struct vm_zone. > sysctl_vm_zone() reminds me too much of Linux procfs where the kernel > wastes a lot of time formatting strings. *groan* don't I know it. The advantage it has over linprocfs is that at least it returns all the data in one piece. With procfs and linprocfs, if the reader uses a small read buffer it can end up with gibberish. I'd really love to have session tracking so I could format the data on open (or on first read) and cache it until the end of that session. > It doesn't even provide > any features that aren't implemented in userland like it did originally, > since dillon implemented vmstat -z (except vmstat -z leaves out some > details). But vmstat -z gropes inside the zone allocator's private parts... and currently doesn't work because I wasn't aware of it until an hour ago, and didn't update it. I'd rather update vm_sysctl_conf() to be more like vmstat -z, and then have vmstat -z simply print its output, than teaching vmstat -z how to fondle the zone allocator's privates. That's simply not done in polite company. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpk87ngpui.fsf>