Date: Mon, 5 Feb 2007 15:54:12 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Eygene Ryabinkin <rea-fbsd@codelabs.ru> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Bruce M Simpson <bms@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_tap.c Message-ID: <20070205125412.GH1621@FreeBSD.org> In-Reply-To: <20070205125244.GO35552@codelabs.ru> References: <200702030257.l132vkfT089439@repoman.freebsd.org> <20070205124332.GG1621@FreeBSD.org> <20070205125244.GO35552@codelabs.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 05, 2007 at 03:52:44PM +0300, Eygene Ryabinkin wrote: E> > btw, we have a strange situation with handling off non-broadcast E> > frames not destined to us in general. E> > E> > In a case, when we have generic Ethernet in promisc, and received foreign E> > packets (on a hub, or a buggy switch), they are forwarded to ether_demux() E> > and to upper layers respectively. Isn't this incorrect? E> > E> > Moreover, in case of promisc + net.inet.ip.forwarding=1 our box will resend E> > all the received foreign packets :( E> > E> > What do you think about checking that (ether_dhost == ours || BCAST || MCAST) E> > before sending packet to ether_demux? E> E> If you will do so, please, do not forget to check if we're doing E> bridging, because your proposal will break it. If I understand the E> things correctly ;)) Don't worry. The bridge input is before ether_demux(). -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070205125412.GH1621>