Date: Tue, 02 Mar 2010 00:26:37 +0100 (CET) From: Alexander Best <alexbestms@wwu.de> To: jhell <jhell@DataIX.net> Cc: freebsd-hackers@freebsd.org Subject: Re: `make cleanworld` and /usr/obj/lib32/usr/src Message-ID: <permail-2010030123263780e26a0b00002540-a_best01@message-id.uni-muenster.de> In-Reply-To: <alpine.BSF.2.00.1002282037330.94904@qvfongpu.qngnvk.ybpny>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a MIME encoded multipart message.
--+permail-2010030123263780e26a0b00002540-a_best01+
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
jhell schrieb am 2010-03-01:
> On Sun, 28 Feb 2010 11:54, alexbestms@ wrote:
> >Gary Jennejohn schrieb am 2010-02-28:
> >>On Sat, 27 Feb 2010 14:49:58 +0100 (CET)
> >>Alexander Best <alexbestms@wwu.de> wrote:
> >>>how about something like this?
> >>Based on a quick look it seems OK to me.
> >>Have you tested it?
> >i did. it works when `make cleanworld` is being run from /usr/src.
> >i'm not
> >sure however what the
> >.if ${.CURDIR} == ${.OBJDIR} || ${.CURDIR}/obj == ${.OBJDIR}
> >.if exists(${BW_CANONICALOBJDIR}/)
> >statement is for so i didn't include the lib32 cleanup in that
> >clause. my
> >guess is that it's used to catch the case where `make cleanworld`
> >is being run
> >in /usr/obj/usr/src
> You can't run make from a obj directory there is no Makefile,
> Targets or spoons. ;)
> This line here:
> BW_CANONICALOBJDIR:=${MAKEOBJDIRPREFIX}${.CURDIR}
> Allows the end-user to set MAKEOBJDIRPREFIX in their environment and
> have the obj directory somewhere other than CANONICALOBJDIR.
sorry. the patch contained spaces instead of tabs making it fail when deleting
lib32. here's the right patch. sorry for the noise.
i'll submit this patch along with a few style cleanups of Makefile as a pr so
the changes don't get lost.
alex
> BW is an abbreviation for "buildworld".
> >cheers.
> >alex
> >>---
> >>Gary Jennejohn
> >_______________________________________________
> >freebsd-hackers@freebsd.org mailing list
> >http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> >To unsubscribe, send any mail to
> >"freebsd-hackers-unsubscribe@freebsd.org"
> --
> jhell
--+permail-2010030123263780e26a0b00002540-a_best01+
Content-Type: text/plain
Content-Transfer-Encoding: Base64
Content-Disposition: attachment; filename="makefile.patch.txt"
SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIE1ha2VmaWxlCShyZXZpc2lvbiAyMDQ1NDAp
CisrKyBNYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMTU5LDYgKzE1OSwxMSBAQAogCS1jaGZs
YWdzIC1SIDAgJHsuT0JKRElSfQogCXJtIC1yZiAkey5PQkpESVJ9LyoKIC5lbmRpZgorLmlmIGV4
aXN0cygke01BS0VPQkpESVJQUkVGSVh9L2xpYjMyJHsuQ1VSRElSfS8pCisJLXJtIC1yZiAke01B
S0VPQkpESVJQUkVGSVh9L2xpYjMyJHsuQ1VSRElSfS8qCisJLWNoZmxhZ3MgLVIgMCAke01BS0VP
QkpESVJQUkVGSVh9L2xpYjMyJHsuQ1VSRElSfSAgCisJcm0gLXJmICR7TUFLRU9CSkRJUlBSRUZJ
WH0vbGliMzIkey5DVVJESVJ9LyoKKy5lbmRpZgogCiAjCiAjIEhhbmRsZSB0aGUgdXNlci1kcml2
ZW4gdGFyZ2V0cywgdXNpbmcgdGhlIHNvdXJjZSByZWxhdGl2ZSBtayBmaWxlcy4K
--+permail-2010030123263780e26a0b00002540-a_best01+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?permail-2010030123263780e26a0b00002540-a_best01>