Date: Fri, 13 Jul 2012 09:20:13 +1000 From: Peter Jeremy <peter@rulingia.com> To: John Baldwin <jhb@freebsd.org> Cc: scottl@freebsd.org, current@freebsd.org Subject: Re: Adding support for WC (write-combining) memory to bus_dma Message-ID: <20120712232013.GA34754@server.rulingia.com> In-Reply-To: <201207121040.27116.jhb@freebsd.org> References: <201207121040.27116.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Jul-12 10:40:27 -0400, John Baldwin <jhb@freebsd.org> wrote: >contigmalloc(). In fact, even better is to call kmem_alloc_contig() direc= tly >rather than using contigmalloc(). =2E.. >Peter, this is somewhat orthognal (but related) to your bus_dma patch whic= h is >what prompted me to post this. Overall, the change seems good to me. My sole thought on the API was whether the actual attribute should be passed, rather than having a couple of new BUS_DMA_ flags but you've addressed that in a followup. One change is that previously allocated memory was all charged to M_DEVBUF via the malloc_type_allocated() call in contigmalloc() whereas now only small allocations are counted. This would seem to indicate that large bus_dmamem_alloc() allocations won't be visible in (eg) "vmstat -m". --=20 Peter Jeremy --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk//W60ACgkQ/opHv/APuIdr6QCdHk7mMLXvzlKh6fBfaNi9q5sn pEkAnR/oKgGStC/HYMpkBBlx3bO2Fj4B =DKsp -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120712232013.GA34754>