Date: Fri, 11 Dec 2009 16:58:25 GMT From: Paul <onemda@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/141376: ndis: broken scan Message-ID: <200912111658.nBBGwPnR019353@www.freebsd.org> Resent-Message-ID: <200912111700.nBBH0BuH097732@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 141376
>Category: kern
>Synopsis: ndis: broken scan
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Dec 11 17:00:11 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Paul
>Release:
>Organization:
>Environment:
FreeBSD dhcppc0 9.0-CURRENT FreeBSD 9.0-CURRENT #3 r200402: Fri Dec 11 10:27:58 UTC 2009 r@dhcppc0:/usr/obj/usr/src/sys/kernel i386
>Description:
Scan routine from if_ndis.c does not pass ies to net80211 causing that RSN ie can not be detected - so no authentication with such AP can happen.
>How-To-Repeat:
# ifconfig wlanY create wlandev ndisX
# ifconfig wlanY list scan
# ifconfig -v wlanY list scan
>Fix:
Pass ies and ies_len pointer to net80211
Patch attached with submission follows:
--- /sys/dev/if_ndis/if_ndis.c 2009-12-02 19:09:58.000000000 +0000
+++ if_ndis.c 2009-12-02 20:40:15.000000000 +0000
@@ -3299,24 +3299,11 @@
efrm = frm + wb->nwbx_ielen;
if (efrm - frm < 12)
goto done;
- sp.tstamp = frm;
- frm += 8;
- sp.bintval = le16toh(*(uint16_t *)frm);
- frm += 2;
- sp.capinfo = le16toh(*(uint16_t *)frm);
- frm += 2;
-
- /* Grab variable length ies */
- while (efrm - frm > 1) {
- if (efrm - frm < frm[1] + 2)
- break;
- switch (*frm) {
- case IEEE80211_ELEMID_RSN:
- sp.rsn = frm;
- break;
- }
- frm += frm[1] + 2;
- }
+ sp.tstamp = frm; frm += 8;
+ sp.bintval = le16toh(*(uint16_t *)frm); frm += 2;
+ sp.capinfo = le16toh(*(uint16_t *)frm); frm += 2;
+ sp.ies = frm;
+ sp.ies_len = efrm - frm;
}
done:
DPRINTF(("scan: bssid %s chan %dMHz (%d/%d) rssi %d\n",
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912111658.nBBGwPnR019353>