Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Jan 2001 16:48:58 +0300 (MSK)
From:      ls@berkeley.gambit.com.ru
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/24657: ports/graphics/GIFgraph FIX
Message-ID:  <20010126134858.07A47301D6@berkeley.gambit.com.ru>

next in thread | raw e-mail | index | archive | help

>Number:         24657
>Category:       ports
>Synopsis:       ports/graphics/GIFgraph FIX
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 26 05:50:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Sergii Laskavyi
>Release:        FreeBSD 4.2-STABLE i386
>Organization:
http://ls.si.ru/
>Environment:

graphics/GIFgraph/Makefile:
     $FreeBSD: ports/graphics/GIFgraph/Makefile,v 1.7 2000/10/29 22:58:06 steve Exp $

graphics/p5-GD/Makefile:
     $FreeBSD: ports/graphics/p5-GD/Makefile,v 1.20 2000/11/15 11:03:06 demon Exp $

>Description:

graphics/GIFgraph use image creation methods from graphics/p5-GD package.

Current p5-GD version don't support GIF generation, only PNG.

I am the port MAINTAINER and I suggest to apply the following patch to the
GIFgraph port to use PNG methods from p5-GD.

>How-To-Repeat:

	# update ports

	# remove old p5-GD package to force installation of new p5-GD

	cd ports/graphics/GIFgraph && make install clean

	# try to run any code that use GIFgraph
	# -- it will fail due to removed GIF support

>Fix:

	Download new GIFgraph port skeleton from

		http://ls.si.ru/FreeBSD/GIFgraph.tar.gz
	
	Or apply the following patch:

--- GIFgraph./Makefile	Mon Oct 30 01:58:06 2000
+++ GIFgraph/Makefile	Wed Jan 24 14:28:51 2001
@@ -5,15 +5,16 @@
 # $FreeBSD: ports/graphics/GIFgraph/Makefile,v 1.7 2000/10/29 22:58:06 steve Exp $
 #
 
-PORTNAME=	p5-GIFgraph
+PORTNAME=	GIFgraph
 PORTVERSION=	1.10
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics perl5
 MASTER_SITES=	${MASTER_SITE_PERL_CPAN}
 MASTER_SITE_SUBDIR=	GIFgraph
+PKGNAMEPREFIX=	p5-
 DISTNAME=	GIFgraph-${PORTVERSION}
 
-MAINTAINER=	laskavy@gambit.msk.su
+MAINTAINER=	ls@gambit.com.ru
 
 RUN_DEPENDS=	${LOCALBASE}/lib/perl5/site_perl/${PERL_VER}/${PERL_ARCH}/GD.pm:${PORTSDIR}/graphics/p5-GD
 
@@ -22,7 +23,10 @@
 MANPREFIX=	${PREFIX}/lib/perl5/${PERL_VERSION}
 MAN3=		GIFgraph.3 GIFgraph::colour.3
 
+post-patch:
+	find ${WRKSRC} -name '*.orig' -delete
+
 do-configure:
-		@cd ${WRKSRC}; ${SETENV} ${CONFIGURE_ENV} ${PERL5} Makefile.PL
+	@cd ${WRKSRC}; ${SETENV} ${CONFIGURE_ENV} ${PERL5} Makefile.PL
 
 .include <bsd.port.mk>
--- GIFgraph./files/patch-aa	Thu Jan  1 03:00:00 1970
+++ GIFgraph/files/patch-aa	Fri Jan 26 16:42:39 2001
@@ -0,0 +1,42 @@
+--- GIFgraph./axestype.pm	Wed Aug 26 03:37:14 1998
++++ GIFgraph/axestype.pm	Tue Jan 23 19:21:04 2001
+@@ -116,7 +116,7 @@
+ 		$self->draw_data($self->{graph}, $data);
+ 		$self->draw_legend($self->{graph});
+ 
+-		return $self->{graph}->gif
++		return $self->{graph}->png
+ 	}
+ 
+ 	sub set_x_label_font($) # (fontname)
+--- GIFgraph./pie.pm	Wed Aug 26 03:28:51 1998
++++ GIFgraph/pie.pm	Tue Jan 23 19:23:09 2001
+@@ -53,7 +53,7 @@
+ 		$self->draw_pie($self->{graph});
+ 		$self->draw_data($data, $self->{graph});
+ 
+-		return $self->{graph}->gif;
++		return $self->{graph}->png;
+ 	}
+  
+ 	sub set_label_font($) # (fontname)
+--- GIFgraph.pm.	Wed Aug 26 03:28:48 1998
++++ GIFgraph.pm	Tue Jan 23 19:31:49 2001
+@@ -373,7 +373,7 @@
+ 
+         open(GIFLOGO, $self->{logo}) || return;
+ 		binmode(GIFLOGO) if ($GIFgraph::needs_binmode);
+-        unless ( $glogo = newFromGif GD::Image(\*GIFLOGO) ) 
++        unless ( $glogo = newFromPng GD::Image(\*GIFLOGO) ) 
+ 		{
+             warn "Problems reading $self->{logo}"; 
+ 			close(GIFLOGO); 
+@@ -465,7 +465,7 @@
+ 	{
+         my $s = shift;
+ 
+-        return $s->{graph}->gif;
++        return $s->{graph}->png;
+     }
+ 
+ } # End of package GIFgraph
--- GIFgraph./pkg-comment	Sat Jun 26 21:42:45 1999
+++ GIFgraph/pkg-comment	Wed Jan 24 14:32:02 2001
@@ -1 +1 @@
-A Perl package to generate GIF charts
+A Perl package to generate PNG charts
--- GIFgraph./pkg-descr	Sat Dec 12 18:09:17 1998
+++ GIFgraph/pkg-descr	Wed Jan 24 14:32:25 2001
@@ -1,2 +1,2 @@
-This is GIFgraph, a package to generate GIF charts,
+This is GIFgraph, a package to generate PNG charts,
 using Lincoln Stein's GD.pm.

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010126134858.07A47301D6>