Date: Mon, 10 Feb 2014 08:52:32 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, John Marino <marino@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: svn commit: r343559 - head/net-p2p/litecoin Message-ID: <20140210075232.GU80056@ithaqua.etoilebsd.net> In-Reply-To: <20140210011718.GA79272@mouf.net> References: <201402092329.s19NTHiq089517@svn.freebsd.org> <20140210011718.GA79272@mouf.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--cqG5pBpskktEuCrX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2014 at 01:17:22AM +0000, Steve Wills wrote: > On Sun, Feb 09, 2014 at 11:29:17PM +0000, John Marino wrote: > > Author: marino > > Date: Sun Feb 9 23:29:16 2014 > > New Revision: 343559 > > URL: http://svnweb.freebsd.org/changeset/ports/343559 > > QAT: https://qat.redports.org/buildarchive/r343559/ > >=20 > > Log: > > net-p2p/litecoin: Fix DragonFly (broken by OSVERSION) > > =20 > > Limit OSVERSION-based modifications to FreeBSD. This port suddenly > > broken and the use of OSVERSION without OPSYS was the cause. > >=20 > > Modified: > > head/net-p2p/litecoin/Makefile > >=20 > > Modified: head/net-p2p/litecoin/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/net-p2p/litecoin/Makefile Sun Feb 9 23:18:17 2014 (r343558) > > +++ head/net-p2p/litecoin/Makefile Sun Feb 9 23:29:16 2014 (r343559) > > @@ -75,7 +75,7 @@ QMAKE_USE_DBUS=3D 0 > > PLIST_FILES+=3D share/applications/litecoin-qt.desktop share/pixmaps/l= itecoin64.png > > .endif > > =20 > > -.if ${OSVERSION} >=3D 1000054 > > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1000054 > > EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-endian > > .endif > > =20 >=20 > Shouldn't this have required maintainer approval? Or am I confused? >=20 I do not think that requires an approval, as for FreeBSD this change is no-= op, It is also no intrusive and just "fixes" building of that port for Dragonfl= y. My 2ct, Bapt --cqG5pBpskktEuCrX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlL4hUAACgkQ8kTtMUmk6ExUdgCbBeeN5fVSRYKiHTsehCgjlZ9/ 4eQAoKYGvZoxu28gP1SoCjPpst3tk+og =5Col -----END PGP SIGNATURE----- --cqG5pBpskktEuCrX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140210075232.GU80056>