Date: Mon, 11 Aug 2014 10:21:55 +0100 From: Matthew Seaman <matthew@freebsd.org> To: Vsevolod Stakhov <vsevolod@FreeBSD.org>, Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Tijl Coosemans <tijl@freebsd.org>, Matthias Andree <matthias.andree@gmx.de>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r364287 - head/ports-mgmt/pkg-devel Message-ID: <53E88B33.8000109@freebsd.org> In-Reply-To: <53E87E4B.5090600@FreeBSD.org> References: <53e39939.55bc.4ca5432c@svn.freebsd.org> <20140807172841.58633e63@kalimero.tijl.coosemans.org> <53E3A468.5050603@FreeBSD.org> <53E3AC0C.5020904@gmx.de> <53E3AD09.2050000@FreeBSD.org> <53E3B3B5.9000104@gmx.de> <53E3B6D8.9080101@FreeBSD.org> <53E590AC.4020105@FreeBSD.org> <53E7A512.8050008@FreeBSD.org> <b1c74ebef13a04a7198ed4a34134d63a@shatow.net> <53E7D193.3090305@FreeBSD.org> <53E7F110.7010105@FreeBSD.org> <53E87E4B.5090600@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wsXLwAgMn3lJDBBgxXL5TtpV73PE978qj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/11/14 09:26, Vsevolod Stakhov wrote: > I agree with this. But we need to define the policy of significant > fields thus. The pull request I've mentioned previously changes this > policy. But I still have no sane comments about it from the ports > developers... >=20 > https://github.com/freebsd/pkg/pull/911 As I see it, if there's a change to any of the fields that go towards creating the package digest, then we're requiring all the users to update that package. This should be avoided for trivial changes. So, switching the question round: what fields in the manifest should *not* imply reinstalling the package? - comment - description - categories (these don't have much effect for binary packages) - www - maintainer (hmmm... not sure. We wouldn't want to have former maintainers still being pestered about their old ports.) - annotations Anything that relates to the actual package contents -- so changes to the list of files and their checksums (assuming we have reproducible builds? I can't remember if we do or not), changes to scripts, dependencies, required shlibs, etc. definitely is a cause for a reinstall of a package. (Although shlib changes would necessarily mean changes to file checksums. Arch, flat size too). Similarly changes to licenses. Package name and origin together are the unique identifier, so should remain constant -- or else it's going to be treated as a different package[*]. Curiously though, while the package version should change with any update to the package content, just changing the version number on alone probably isn't cause for reinstalling the package. Cheers, Matthew [*] Maybe we should be tracking old name / origin data (ie. relevant bits of /usr/ports/MOVED) within package metadata? --wsXLwAgMn3lJDBBgxXL5TtpV73PE978qj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJT6Is6XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQxOUYxNTRFQ0JGMTEyRTUwNTQ0RTNGMzAw MDUxM0YxMEUwQTlFNEU3AAoJEABRPxDgqeTnqP0P/R1BFPW2YuhdIWcg+mtV8ooB 8K+DlFlIrEOGZOHRqKARrCL5NEymSDoZQw6hJiRZ2o0qEdIAHYeiMiPE0rvQb6lK PNj98bz+6mUldKWI1obHnk6LNpoHrx9YaGpUiVRdAuv794R4yH8uuot4srDU6QYh SFOdsY92mJFre6kNB6eGFZ7bm6g2twXtFZfwFcdcDc/XDHIukR+EGm8Xd1Jd2Tsj SiPMGGNvLGWP2ap/0t9AzgQKlTgOm3NpOsaZ/bUFJbx6BPvqk2xOu4BrzTBPXjs9 ewXafbQoNmrmYu5ugD4X3Zm/Fi7/U6V44hOUXpuL/TAIbLqYgPTR10EJDUpRF8B9 ASXrjwmBb6Okq81t0iBoAtye4jE/j2SuE4z4YN7DWXVxAEt1F8i2JjEB+mzamMFD f7jkL3Atj1A/TBfpizsQSch7N5/Cwk4qL76aHx10LCvpuZKBNea6WvY/YZhEaB24 XQ24O3LypLqRqpZaBrI3JNRsB5pB2oPpF/mEo8ZvXBVOhPzQ57gE3k//bCRMo5L5 sPOZbQwkqL4cWwQ09vEXd1qDSRe88/I838pqONlbvl7aPxeouoZfcTg+RvZFXeJe yUnmB4bL7TYRFCWmUirdbKZ8GTrFio2rjPMHPanw6z7+O+DHrDvgaX2uvRapEekH 0pX50YExZ56tz5zIMHHT =U0yG -----END PGP SIGNATURE----- --wsXLwAgMn3lJDBBgxXL5TtpV73PE978qj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53E88B33.8000109>