Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Mar 2003 15:19:10 -0700 (US Mountain Standard Time)
From:      Steve Grandi <grandi@noao.edu>
To:        "Justin T. Gibbs" <gibbs@scsiguy.com>
Cc:        scsi@freebsd.org
Subject:   Re: Latest aic7xxx/aic79xx diffs for stable
Message-ID:  <Pine.WNT.4.53.0303031511550.1312@rigel>
In-Reply-To: <1603440000.1046725015@aslan.btc.adaptec.com>
References:  <1603440000.1046725015@aslan.btc.adaptec.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 3 Mar 2003, Justin T. Gibbs wrote:

> I've uploaded the latest set of changes for the -stable versions
> of the aic7xxx and aic79xx drivers here:
>
> http://people.freebsd.org/~gibbs/aic7xxx-FreeBSD-20030303.diffs.gz
>
> I would appreciate feedback on them prior to merging them back into
> the stable branch.
>
> Thanks,
> Justin
>

I've tried to apply these patches, but there are some "notational"
problems that keep them from going in cleanly.

For example, in aic79xx.seq, the STABLE source says:

        SET_MODE(M_SCSI, M_SCSI)
        bmov    SCBPTR, ARG_1, 2;
queue_scb_completion:
        if ((ahd->bugs & AHD_ABORT_LQI_BUG) == 0) {

while the patch refers to:

@@ -1030,14 +1032,6 @@
        SET_MODE(M_SCSI, M_SCSI)
        bmov    SCBPTR, ARG_1, 2;
 queue_scb_completion:
-       if ((ahd-&gt;bugs &amp; AHD_ABORT_LQI_BUG) == 0) {

note the difference between "ahd->bugs" and "ahd-&gt;bugs"

Am I missing some preprocessing step or another?
-- 
Steve Grandi
National Optical Astronomy Observatory/AURA Inc., Tucson AZ USA
Internet: grandi@noao.edu  Voice: +1 520 318-8228  FAX: +1 520 318-8360

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-scsi" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.WNT.4.53.0303031511550.1312>