Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 Jul 2005 18:04:01 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 79850 for review
Message-ID:  <200507091804.j69I41Fj081215@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=79850

Change 79850 by rwatson@rwatson_zoo on 2005/07/09 18:04:01

	When the mount MAC Framework entry point was expanded to included a
	requested mount label, most policies were not updated to recognize
	the additional argument.  Add it to the function declarations, and
	add comments where we likely should be doing something with the
	argument.

Affected files ...

.. //depot/projects/trustedbsd/sebsd/sys/security/mac_biba/mac_biba.c#15 edit
.. //depot/projects/trustedbsd/sebsd/sys/security/mac_lomac/mac_lomac.c#16 edit
.. //depot/projects/trustedbsd/sebsd/sys/security/mac_mls/mac_mls.c#14 edit
.. //depot/projects/trustedbsd/sebsd/sys/security/mac_stub/mac_stub.c#12 edit

Differences ...

==== //depot/projects/trustedbsd/sebsd/sys/security/mac_biba/mac_biba.c#15 (text+ko) ====

@@ -906,10 +906,12 @@
 
 static void
 mac_biba_create_mount(struct ucred *cred, struct mount *mp,
-    struct label *mntlabel, struct label *fslabel)
+    struct label *mntlabel, struct label *fslabel,
+    struct label *mount_arg_label)
 {
 	struct mac_biba *source, *dest;
 
+	/* XXXRW: No use of mount_arg_label here yet. */
 	source = SLOT(cred->cr_label);
 	dest = SLOT(mntlabel);
 	mac_biba_copy_effective(source, dest);

==== //depot/projects/trustedbsd/sebsd/sys/security/mac_lomac/mac_lomac.c#16 (text+ko) ====

@@ -965,10 +965,12 @@
 
 static void
 mac_lomac_create_mount(struct ucred *cred, struct mount *mp,
-    struct label *mntlabel, struct label *fslabel)
+    struct label *mntlabel, struct label *fslabel,
+    struct label *mount_arg_label)
 {
 	struct mac_lomac *source, *dest;
 
+	/* XXXRW: No use of mount_arg_label here yet. */
 	source = SLOT(cred->cr_label);
 	dest = SLOT(mntlabel);
 	mac_lomac_copy_single(source, dest);

==== //depot/projects/trustedbsd/sebsd/sys/security/mac_mls/mac_mls.c#14 (text+ko) ====

@@ -873,10 +873,12 @@
 
 static void
 mac_mls_create_mount(struct ucred *cred, struct mount *mp,
-    struct label *mntlabel, struct label *fslabel)
+    struct label *mntlabel, struct label *fslabel,
+    struct label *mount_arg_label)
 {
 	struct mac_mls *source, *dest;
 
+	/* XXXRW: No use of mount_arg_label here yet. */
 	source = SLOT(cred->cr_label);
 	dest = SLOT(mntlabel);
 	mac_mls_copy_effective(source, dest);

==== //depot/projects/trustedbsd/sebsd/sys/security/mac_stub/mac_stub.c#12 (text+ko) ====

@@ -217,7 +217,8 @@
 
 static void
 stub_create_mount(struct ucred *cred, struct mount *mp,
-    struct label *mntlabel, struct label *fslabel)
+    struct label *mntlabel, struct label *fslabel,
+    struct label *mount_arg_label)
 {
 
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507091804.j69I41Fj081215>