Date: Wed, 16 Apr 2003 11:35:07 -0700 From: Alfred Perlstein <bright@mu.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/wl if_wl.c Message-ID: <20030416183507.GL18848@elvis.mu.org> In-Reply-To: <XFMail.20030416140625.jhb@FreeBSD.org> References: <200304161742.h3GHgc0l085079@repoman.freebsd.org> <XFMail.20030416140625.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* John Baldwin <jhb@FreeBSD.org> [030416 11:06] wrote: > > On 16-Apr-2003 John Hay wrote: > > jhay 2003/04/16 10:42:38 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/wl if_wl.c > > Log: > > Add locking and remove all the spl() calls. > > Note that some of the spl calls covered structures other than > just the softc. I'd prefer that we leave spl calls in until > all the structures they cover are locked. John is right, leaving spls in is the right thing to do until we're pretty much _done_ with smp locking the entire kernel. They serve as a good marker where there may be cross domain locking issues. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.'
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030416183507.GL18848>