Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Mar 2002 10:46:54 -0700 (MST)
From:      "M. Warner Losh" <imp@village.org>
To:        phk@critter.freebsd.dk
Cc:        kris@obsecurity.org, roberto@eurocontrol.fr, freebsd-current@FreeBSD.ORG
Subject:   Re: Time counter broken? 
Message-ID:  <20020328.104654.74403212.imp@village.org>
In-Reply-To: <17301.1017317101@critter.freebsd.dk>
References:  <20020328034747.B98857@xor.obsecurity.org> <17301.1017317101@critter.freebsd.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <17301.1017317101@critter.freebsd.dk>
            Poul-Henning Kamp <phk@critter.freebsd.dk> writes:
: 
: I think I found a mistake I made, can you try this patch please ?
: 
: Index: kern_tc.c
: ===================================================================
: RCS file: /home/ncvs/src/sys/kern/kern_tc.c,v
: retrieving revision 1.117
: diff -u -r1.117 kern_tc.c
: --- kern_tc.c	19 Mar 2002 21:24:06 -0000	1.117
: +++ kern_tc.c	28 Mar 2002 12:00:13 -0000
: @@ -241,7 +241,7 @@
:  	 * The range is +/- 500PPM so we can multiply by about 8500
:  	 * without overflowing.  4398/1024 = is very close to ideal.
:  	 */
: -	scale += (tc->tc_adjustment * 4398) >> 10;
: +	scale += (tc->tc_adjustment * 4398) >> 11;
:  	scale /= tc->tc_tweak->tc_frequency;
:  	tc->tc_scale = scale * 2;
:  }

This patch is broken because it doesn't fix the comment, which should
read
	... 4398 / 2048 is very close to ideal.

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020328.104654.74403212.imp>