Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Jun 2005 22:24:47 -1000
From:      juli mallett <jmallett@FreeBSD.org>
To:        Brian Fundakowski Feldman <green@freebsd.org>
Cc:        cvs-src@freebsd.org, alfred@freebsd.org, cvs-all@freebsd.org, src-developers@freebsd.org
Subject:   Re: cvs commit: src/sys/nfsclient nfs_bio.c nfs_vfsops.c nfsargs.h nfsmount.h src/sys/sys buf.h bufobj.h src/sys/kern vfs_bio.c
Message-ID:  <20050611082446.GA54459@toxic.magnesium.net>
In-Reply-To: <20050611064956.GC66188@green.homeunix.org>
References:  <200506102350.j5ANofFM008212@repoman.freebsd.org> <20050611034930.GY17867@elvis.mu.org> <20050611064956.GC66188@green.homeunix.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* Brian Fundakowski Feldman <green@freebsd.org> [ Date: 2005-06-10 ]
	[ w.r.t. Re: cvs commit: src/sys/nfsclient nfs_bio.c nfs_vfsops.c nfsargs.h nfsmount.h src/sys/sys buf.h bufobj.h src/sys/kern vfs_bio.c ]
> On Fri, Jun 10, 2005 at 08:49:30PM -0700, Alfred Perlstein wrote:
> > Returning EAGAIN from a disk IO seems bogus, are you sure it makes
> > sense to do that when IO_NDELAY is set?  Shouldn't it just be ignored
> > like other FSes do?
> 
> Well, it's not disk IO, it's network IO.  I figure if you set that
> flag you should expect commensurate error return values.  This is
> conceivably a useful behavior, and POSIX does not forbid it, so I just
> made the judgement call to not deny the functionality.
> 
> Would you actually be surprised to get EAGAIN if you requested
> non-blocking access to a file stream, ignoring the fact that it just
> happens to not have been done already for other S_ISREG file streams?

There's a surprisingly good email from Terry about this here:
http://lists.freebsd.org/pipermail/freebsd-current/2003-April/000356.html

In short, green wins.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050611082446.GA54459>