Date: Thu, 11 Jul 2002 21:54:29 -0700 (PDT) From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 14125 for review Message-ID: <200207120454.g6C4sTax009797@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14125 Change 14125 by rwatson@rwatson_paprika on 2002/07/11 21:54:24 Back out the lazy instantiate component of @14031, as it broke mount-derived labels on multilabel (read-only or full) file systems, as the EA write could result in a failure of the label refresh, even though a valid label is available. Approved by: green Affected files ... .. //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#164 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#164 (text+ko) ==== @@ -913,18 +913,11 @@ case ENOATTR: /* - * Use the label from the mountpoint. Take this opportunity - * to lazy-instantiate, just for correctness. + * Use the label from the mountpoint. */ mac_update_vnode_from_mount(vp, vp->v_mount); - error = mac_externalize(&vp->v_label, &extmac); - if (error) - return (error); - error = vn_extattr_set(vp, IO_NODELOCKED, - FREEBSD_MAC_EXTATTR_NAMESPACE, FREEBSD_MAC_EXTATTR_NAME, - sizeof(extmac), (char *)&extmac, curthread); - if (error == 0) - break; + return (0); + case EOPNOTSUPP: default: /* Fail horribly. */ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207120454.g6C4sTax009797>