Date: Sun, 4 Sep 2011 03:57:30 GMT From: Gerald Pfeifer <gerald@pfeifer.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/160448: ports-mgmt/portlint shall warn about CPPFLAGS being passed to MAKE_ENV Message-ID: <201109040357.p843vUn8033278@ref9-i386.freebsd.org> Resent-Message-ID: <201109040400.p8440KpF065906@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 160448 >Category: ports >Synopsis: ports-mgmt/portlint shall warn about CPPFLAGS being passed to MAKE_ENV >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Sep 04 04:00:19 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Gerald Pfeifer >Release: >Organization: >Environment: >Description: This is the part of ports/155550 that has not been addressed there. Recently a change of mine to pass CPPFLAGS to MAKE_ENV has been applied to Mk/bsd.port.mk. In consequence, individual ports no long should pass this explicitly and portlint should warn about MAKE_ENV= CPPFLAGS="${CPPFLAGS}" In fact any setting of CPPFLAGS, also along the lines of MAKE_ENV= CPPFLAGS="-Dfoo -D bar" should be warned about since, really, CPPFLAGS should be set in the port Makefile and the rest should "just happen". >How-To-Repeat: Run portlint -C against revision 1.32 of Makefile in finance/quantlib. >Fix: >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109040357.p843vUn8033278>