Date: Wed, 28 Aug 2013 13:14:23 +0200 From: Davide Italiano <davide@freebsd.org> To: Ivan Voras <ivoras@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r254986 - head/sys/ufs/ufs Message-ID: <CACYV=-H3zKuBizj%2B4Zq2DuCc-Tstaadr9mtxVypw9zLG4dSejQ@mail.gmail.com> In-Reply-To: <CAF-QHFVmW=jSKkJCbyLnJXoSwieDELrUyKHjwdQXM0Urpvbb%2Bg@mail.gmail.com> References: <201308281006.r7SA6KSq010737@svn.freebsd.org> <CACYV=-GtV5vwsd5zWX6=i-z2yHND8rZT_dWXhdjnBhMb4jjTvw@mail.gmail.com> <CAF-QHFU-cdd2b-7PHwFW8H2Unmtpp4iid3bZwmqfwKVk3cR=-g@mail.gmail.com> <CACYV=-FfjZrOqfOitmvs78N=L38dzzaWsVhMbQHnVC0g1CP1VQ@mail.gmail.com> <CAF-QHFVmW=jSKkJCbyLnJXoSwieDELrUyKHjwdQXM0Urpvbb%2Bg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 28, 2013 at 12:53 PM, Ivan Voras <ivoras@freebsd.org> wrote: > On 28 August 2013 12:44, Davide Italiano <davide@freebsd.org> wrote: > >> Do you realize that this is a driven by commit change, right? And >> there's no technical motivatiion about this or experimental data that >> confirms you've chossen the right value? > >> I see from the archives that you didn't get any feedback by anyone >> working in the VM layer or by some UFS maintainer. >> I don't even comment about discussing -CURRENT changes in stable@. > > You have a point that this was a judgment call, but note that the last > change to dirhash tuning (maxmem) was also done by me. Since this is > -CURRENT, I will leave this commit in unless it proves detrimental in > the usual testing which goes on. > If 10.0 would be one or two years away, I would be OK with that. But we're already in code slush and in 10 days -CURRENT will become -STABLE'ish so I'm worried this change won't have the right exposure. I would be more happy to see it postponed, maybe after proper discussion and testing. I'm not against the change as-it-is, my point is that the project reached a point of maturity where 'judgment calls' doesn't work very well. It's more a matter of "how things are done" rather than "what things are done". > If you still feel strongly about this, contact me in private and we'll > investigate its effects in more detail. I prefer to see a public discussion about this. Maybe you should come up with some evidence that your change is helpful, even after this commit. -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACYV=-H3zKuBizj%2B4Zq2DuCc-Tstaadr9mtxVypw9zLG4dSejQ>