Date: Wed, 21 Apr 2004 13:54:54 +0200 (CEST) From: Volker Stolz <vs@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: kcwu@csie.org Subject: ports/65848: [patch] Unbreak textproc/iiimf-csconv Message-ID: <200404211154.i3LBsspv039821@menelaos.informatik.rwth-aachen.de> Resent-Message-ID: <200404211200.i3LC0gDH051050@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 65848 >Category: ports >Synopsis: [patch] Unbreak textproc/iiimf-csconv >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Apr 21 05:00:42 PDT 2004 >Closed-Date: >Last-Modified: >Originator: Volker Stolz >Release: FreeBSD 4.9-STABLE i386 >Organization: Lehrstuhl für Informatik II >Environment: System: FreeBSD menelaos.informatik.rwth-aachen.de 4.9-STABLE FreeBSD 4.9-STABLE #15: Thu Mar 25 15:34:34 CET 2004 root@menelaos.informatik.rwth-aachen.de:/usr/obj/usr/src/sys/MENELAOS i386 >Description: iiimv-cscons fails to build on bento because it use -pthread and -lc at the same time, seemingly leading to some stack smashing, cf. http://bento.freebsd.org/errorlogs/i386-4-full/iiimf-csconv-r11.4_1.log cc: maintainer >How-To-Repeat: Build the port. >Fix: Strip explicit -lc from command lines; passing -lc should never be necessary(?). The patch below doesn't eliminate all occurrences of -lc in the port, but at least unbreaks the build. The maintainer should investigate if this is sufficient. Maybe the patch could be integrated into the port's current post-patch infrastructure, but I couldn't think of a suitable regex for REINPLACE. The patch works on -STABLE and -CURRENT. Existing patch modified and a new patch added: --- iiimf-csconv begins here --- Index: files/patch-lib_CSConv_configure =================================================================== RCS file: /usr/freebsdcvs/cvs-ports/ports/textproc/iiimf-csconv/files/patch-lib_CSConv_configure,v retrieving revision 1.1 diff -u -r1.1 patch-lib_CSConv_configure --- files/patch-lib_CSConv_configure 28 Dec 2003 11:43:36 -0000 1.1 +++ files/patch-lib_CSConv_configure 21 Apr 2004 10:05:26 -0000 @@ -1,6 +1,22 @@ ---- configure.orig Sat Dec 6 01:28:41 2003 -+++ configure Sat Dec 6 01:28:43 2003 -@@ -6220,6 +6220,7 @@ +--- configure.orig Sat Aug 23 09:33:31 2003 ++++ configure Wed Apr 21 12:04:17 2004 +@@ -2772,7 +2772,6 @@ + echo $ECHO_N "(cached) $ECHO_C" >&6 + else + ac_check_lib_save_LIBS=$LIBS +-LIBS="-lc $LIBS" + cat >conftest.$ac_ext <<_ACEOF + #line $LINENO "configure" + /* confdefs.h. */ +@@ -2819,7 +2818,6 @@ + #define HAVE_LIBC 1 + _ACEOF + +- LIBS="-lc $LIBS" + + fi + +@@ -6220,6 +6218,7 @@ case "${host}" in *solaris*) platform=SOLARIS ;; *linux*) platform=LINUX ;; Index: files/patch-lib_CSConv_converterPI_configure =================================================================== RCS file: files/patch-lib_CSConv_converterPI_configure diff -N files/patch-lib_CSConv_converterPI_configure --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/patch-lib_CSConv_converterPI_configure 21 Apr 2004 10:06:01 -0000 @@ -0,0 +1,18 @@ +--- converterPI/configure.orig Wed Apr 21 12:04:26 2004 ++++ converterPI/configure Wed Apr 21 12:04:34 2004 +@@ -1152,7 +1152,6 @@ + echo $ac_n "(cached) $ac_c" 1>&6 + else + ac_save_LIBS="$LIBS" +-LIBS="-lc $LIBS" + cat > conftest.$ac_ext <<EOF + #line 1158 "configure" + #include "confdefs.h" +@@ -1182,7 +1181,6 @@ + #define $ac_tr_lib 1 + EOF + +- LIBS="-lc $LIBS" + + else + echo "$ac_t""no" 1>&6 --- iiimf-csconv ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404211154.i3LBsspv039821>