Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Mar 2010 21:51:00 +0200
From:      Jaakko Heinonen <jh@FreeBSD.org>
To:        freebsd-geom@FreeBSD.org, pjd@FreeBSD.org
Subject:   geom_label and directories under /dev
Message-ID:  <20100315195059.GA1331@a91-153-117-195.elisa-laajakaista.fi>

next in thread | raw e-mail | index | archive | help

Hi,

I was working to fix problems with GEOM label class allowing some
problematic label names which can't represent proper files under /dev.
For example:

- empty label
- "." and ".."
- labels starting or ending with '/'
- labels ending with /.. (Due to a bug for example /..foo/.. is
  allowed.)

Then I noticed that directories are also problematic. Here's how to
panic your system:

# glabel create ab ad0
# glabel create ab/cd ad0
# ls -l /dev/label

I was going to suggest disallowing of '/' in labels but in past such
change has been reverted.

------------------------------------------------------------------------
r149339 | pjd | 2005-08-20 20:05:47 +0300 (Sat, 20 Aug 2005) | 5 lines

Back-out the change from revision 1.14 and allow for '/' in labels
again.

Convinced by:   green, Gavin Atkinson, dougb, gordon
MFC after:      1 day

------------------------------------------------------------------------

So it's probably a dead end to try to suggest disallowing of '/'?
Unfortunately it's not easy to fix all problems with directories. For
starters devfs doesn't support removal of directories at all.

Opinions?

-- 
Jaakko



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100315195059.GA1331>