Date: Fri, 13 Jul 2007 20:54:14 +1200 From: Andrew Thompson <thompsa@FreeBSD.org> To: d@delphij.net Cc: attilio@freebsd.org, freebsd-current@freebsd.org, Julian Elischer <julian@elischer.org>, Hans Petter Selasky <hselasky@c2i.net> Subject: Re: crash in tty code in 6.1.. fixed since? Message-ID: <20070713085414.GC11395@heff.fud.org.nz> In-Reply-To: <46973A08.3030607@delphij.net> References: <46970DF7.3000803@elischer.org> <46972B28.1010409@FreeBSD.org> <200707131021.59966.hselasky@c2i.net> <46973A08.3030607@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 13, 2007 at 04:38:32PM +0800, LI Xin wrote: > Hans Petter Selasky wrote: > [...] > > Maybe related: > > > > Regarding the keyboard system which is also Giant locked, we should add assert > > Giant statements, because I see several callers doing calls into the keyboard > > system without holding Giant! > > I think that is a good idea. By adding these assertions our user > community would be able to catch more under-exercised codepath under > their workload. Well hopefully the developer adding the assertions would attempt to find them all first rather than 'fishing' for a panic. :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070713085414.GC11395>