Date: Sun, 6 Apr 2003 22:51:49 +0200 From: Martin Husemann <martin@duskware.de> To: Markus Dolze <sm4tnp8@gmx.net> Cc: freebsd-isdn@freebsd.org Subject: Re: Bugs in isdnmonitor? Message-ID: <20030406205149.GA7714@drowsy.duskware.de> In-Reply-To: <9383.1049641491@www53.gmx.net> References: <9383.1049641491@www53.gmx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 06, 2003 at 05:04:51PM +0200, Markus Dolze wrote: > 4. > When trying to implement the "dump rights" message i discovered the > following in isdnmonitor/monitor.h: > I4B_MON_DRINI_CODE = 2 > I4B_MON_IDEV_CODE = 2 > Two messages with the same event code? While this is surely suboptimal, the I4B_MON_IDEV_CODE is only used in the initial isdnd <-> client handshake, with both isdnd and monitor client in a special state. That's why it did not bite in the in-tree implementation. If you do "fgrep _CODE monitor.h" you will notice three ocurances of such code overlaps in statefull protocol sections. I don't realy care to much about changes in this area - if you think it should be made unique, that's fine with me. Martin P.S.: amazing how much interest drops once your environment changes - when I first did the monitor stuff I needed it for work - now neither work nor me privately even use ISDN data conections any more. I have to struggle hard to keep a working testbed connection for ocasional tests configured.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030406205149.GA7714>