Date: Sat, 30 Aug 1997 12:18:42 +1000 From: Bruce Evans <bde@zeta.org.au> To: kato@FreeBSD.ORG, smp@csn.net Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/include param.h Message-ID: <199708300218.MAA02715@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>machine/param.h has what should be a separate .h file appended to it as: > >#ifndef _SIMPLELOCK_H_ >#define _SIMPLELOCK_H_ > ... >#endif /* !_SIMPLELOCK_H_ */ > >I would like to take this section and move it to new file: machine/simplelock.h Me too (except perhaps it should be named machine/lock.h). >This would break a lot of files that currently get this info from param.h. To >get around this in the beginning I would just add: > >#include <machine/simplelock.h> to the end of param.h until all the files >requiring it are found and fixed. I think <machine/simplelock.h> should just be included in <sys/lock.h>. <sys/lock.h> depends on the full `struct simplelock' being defined, so nothing would be lost by this. I tried removing the simplelock declarations completely. This broke only 175 of 568 objects in LINT, mostly for sources that include <sys/lock.h>. <sys/lock.h> is included for approx. 171 of the objects in LINT, so all except approx. 4 cases can be handled by the nested include. It also broke everything that includes <sys/mount.h>, even in the !KERNEL case when struct simplelock is not required, because <sys/mount.h> includes <sys/lock.h> in all cases. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199708300218.MAA02715>