Date: Wed, 13 Nov 2013 19:16:46 GMT From: Matthieu Volat <mazhe@alkumuna.eu> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/183935: [patch] net-p2p/transmission-qt4 and freebsd 10.0 (libc++) Message-ID: <201311131916.rADJGkZi093996@oldred.freebsd.org> Resent-Message-ID: <201311131920.rADJK0OC055461@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 183935
>Category: ports
>Synopsis: [patch] net-p2p/transmission-qt4 and freebsd 10.0 (libc++)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Nov 13 19:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Matthieu Volat
>Release: 10.0-BETA3
>Organization:
>Environment:
FreeBSD justice.alkumuna.eu 10.0-BETA3 FreeBSD 10.0-BETA3 #0 r257580: Sun Nov 3 19:43:01 UTC 2013 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
Here's a minor problem building transmission-qt4 on FreeBSD 10.0 with the new libc++ library:
c++ -c -O2 -pipe -fno-strict-aliasing -g -pthread -D_THREAD_SAFE -Wall -W -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/local/share/qt4/mkspecs/freebsd-clang -I. -I/usr/local/include/qt4/QtCore -I/usr/local/include/qt4/QtNetwork -I/usr/local/include/qt4/QtGui -I/usr/local/include/qt4/QtDBus -I/usr/local/include/qt4 -I/include -I.. -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/event2/compat -I. -I. -I/usr/local/include/qt4 -I/usr/local/include -o app.o app.cc
In file included from app.cc:34:
./app.h:40:10: warning: 'MyApp::notify' hides overloaded virtual function [-Woverloaded-virtual]
bool notify (const QString& title, const QString& body) const;
^
/usr/local/include/qt4/QtGui/qapplication.h:289:10: note: hidden overloaded virtual function 'QApplication::notify' declared here: type mismatch at 1st
parameter ('QObject *' vs 'const QString &')
bool notify(QObject *, QEvent *);
^
1 warning generated.
c++ -c -O2 -pipe -fno-strict-aliasing -g -pthread -D_THREAD_SAFE -Wall -W -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/local/share/qt4/mkspecs/freebsd-clang -I. -I/usr/local/include/qt4/QtCore -I/usr/local/include/qt4/QtNetwork -I/usr/local/include/qt4/QtGui -I/usr/local/include/qt4/QtDBus -I/usr/local/include/qt4 -I/include -I.. -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/event2/compat -I. -I. -I/usr/local/include/qt4 -I/usr/local/include -o dbus-adaptor.o dbus-adaptor.cc
In file included from dbus-adaptor.cc:14:
./app.h:54:5: error: unknown type name 'time_t'
time_t myLastFullUpdateTime;
^
./app.h:40:10: warning: 'MyApp::notify' hides overloaded virtual function [-Woverloaded-virtual]
bool notify (const QString& title, const QString& body) const;
^
/usr/local/include/qt4/QtGui/qapplication.h:289:10: note: hidden overloaded virtual function 'QApplication::notify' declared here: type mismatch at 1st
parameter ('QObject *' vs 'const QString &')
bool notify(QObject *, QEvent *);
^
dbus-adaptor.cc:18:5: error: no matching constructor for initialization of 'QDBusAbstractAdaptor'
QDBusAbstractAdaptor( app ),
^ ~~~
/usr/local/include/qt4/QtDBus/qdbusabstractadaptor.h:57:21: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from
'MyApp *' to 'const QDBusAbstractAdaptor' for 1st argument
class Q_DBUS_EXPORT QDBusAbstractAdaptor: public QObject
^
/usr/local/include/qt4/QtDBus/qdbusabstractadaptor.h:61:5: note: candidate constructor not viable: no known conversion from 'MyApp *' to 'QObject *' for 1st
argument
QDBusAbstractAdaptor(QObject *parent);
^
1 warning and 2 errors generated.
gmake[2]: *** [dbus-adaptor.o] Error 1
gmake[2]: Leaving directory `/usr/ports/net-p2p/transmission-qt4/work/transmission-2.82/qt'
*** Error code 2
Stop.
>How-To-Repeat:
On a 10.0-BETA3 system, try to build net-p2p/transmission-qt4
>Fix:
Simply including <ctime> in qt/app.h solves the problem (patch enclosed).
If paranoid, the patch should be applied depending on the version of the host system, but I think that it is overkill seeing its simplicity :)
Patch attached with submission follows:
--- qt/app.h.orig 2013-11-13 20:00:41.000000000 +0100
+++ qt/app.h 2013-11-13 20:00:51.000000000 +0100
@@ -13,6 +13,7 @@
#ifndef QTR_APP_H
#define QTR_APP_H
+#include <ctime>
#include <QApplication>
#include <QSet>
#include <QTimer>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311131916.rADJGkZi093996>