Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Nov 2006 16:25:27 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Roman Divacky <rdivacky@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 108941 for review
Message-ID:  <200611011625.28582.jhb@freebsd.org>
In-Reply-To: <200611011958.kA1JwQbN022477@repoman.freebsd.org>
References:  <200611011958.kA1JwQbN022477@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 01 November 2006 14:58, Roman Divacky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=108941
> 
> Change 108941 by rdivacky@rdivacky_witten on 2006/11/01 19:57:42
> 
> 	Lock proc in gettid.
> 
> Affected files ...
> 
> .. //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#22 edit
> 
> Differences ...
> 
> ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#22 
(text+ko) ====
> 
> @@ -1408,7 +1408,9 @@
>  		printf(ARGS(gettid, ""));
>  #endif
>  
> +	PROC_LOCK(td->td_proc);
>  	td->td_retval[0] = td->td_proc->p_pid;
> +	PROC_UNLOCK(td->td_proc);
>  	return (0);
>  }

You don't need this.  p_pid is read-only after fork().

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611011625.28582.jhb>