Date: Tue, 07 Sep 1999 22:13:42 -0700 From: Mike Smith <mike@smith.net.au> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/conf files.alpha src/sys/i386/conf files.i386 src/sys/conf files src/sys/dev/sio sio.c src/sys/isa sio.c sioreg.h Message-ID: <199909080513.WAA00469@dingo.cdrom.com> In-Reply-To: Your message of "Wed, 08 Sep 1999 14:50:49 %2B1000." <Pine.BSF.4.10.9909081439330.12081-100000@alphplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > Right now sys/dev/sio has 1 or 2 files. > > > > In the future it will have as many as 10. > > > > sio_isa.c > > sio_pci.c > > sio_mca.c > > sio_eisa.c > > > > etc... > > I hope not. Why not? One file per bus attachment makes a lot of sense. Sticking them all into one core file has proven to be a disaster. > > Keeping all the files for a particular driver in 1 place and not all > > spread out makes propogating changes to the various files a little easier > > to manage no? > > No :-). Would you care to elaborate on what seems to be an unsubstantiated opinion? Taking this stance isn't very helpful - we can't accomodate your concerns if we don't know what they are, leaving no alternative but for us to say "well, Bruce says he doesn't like this but we have no idea why, and nothing else suggests we shouldn't do it like this". > Changes should rarely need to be propagated if the core is properly > designed. E.g., in my cy driver, which is similar to sio, I rarely > had to even look at cy_pci.c. That's debatable, but regardless of the rarity or otherwise, this reduces the argument for aggregating rather than making an argument for forcible separation. OTOH, aggregation means it's much easier to find all of the files associated with a given driver for the purposes of things like building loadable modules. (Yes, I know you don't believe in loadable modules. They do exist, and we do use them...) -- \\ The mind's the standard \\ Mike Smith \\ of the man. \\ msmith@freebsd.org \\ -- Joseph Merrick \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199909080513.WAA00469>