Date: Tue, 20 Jan 2004 20:54:10 -0800 (PST) From: Don Lewis <truckman@FreeBSD.org> To: bde@zeta.org.au Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h Message-ID: <200401210454.i0L4sA7E060634@gw.catspoiler.org> In-Reply-To: <20040120175334.W3279@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 Jan, Bruce Evans wrote: > On Mon, 19 Jan 2004, Poul-Henning Kamp wrote: > >> phk 2004/01/19 13:27:11 PST >> >> FreeBSD src repository >> >> Modified files: >> sys/alpha/alpha support.s >> sys/i386/i386 swtch.s >> sys/kern kern_shutdown.c >> sys/sys systm.h >> Log: >> Add linenumber and source filename to panic(9) output. > > This was rejected in all reviews. It gives less information than > grepping the sources, at some cost (grep at least gives correct line > numbers when the sources don't quite match the binary). One point in favor of including the file name is that it allows the consumer of this information to grep the correct file instead of having to grep all of /usr/src/sys. The line number is pretty useless, though. What about the case of macros like KASSERT() and the vnode lock assertions? Won't they report the name and line number of the #define?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200401210454.i0L4sA7E060634>