Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Dec 2003 18:49:21 -0700 (MST)
From:      "M. Warner Losh" <imp@bsdimp.com>
To:        grog@FreeBSD.org
Cc:        mobile@FreeBSD.org
Subject:   Re: Still problems with Lucent wi0
Message-ID:  <20031211.184921.67799178.imp@bsdimp.com>
In-Reply-To: <20031212012532.GB81968@wantadilla.lemis.com>
References:  <20031212010434.GY81968@wantadilla.lemis.com> <20031211.181241.58839617.imp@bsdimp.com> <20031212012532.GB81968@wantadilla.lemis.com>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20031212012532.GB81968@wantadilla.lemis.com>
            "Greg 'groggy' Lehey" <grog@FreeBSD.org> writes:
: On Thursday, 11 December 2003 at 18:12:41 -0700, M. Warner Losh wrote:
: > Are you runnign current?
: 
: For some definition of "current", yes.  30 November.

That's not current enough.  I committed the fixes for that the next
day:

imp         2003/12/01 20:59:59 PST

  FreeBSD src repository

  Modified files:
    sys/dev/wi           if_wi.c 
  Log:
  Fix Lucent cards.
  o Back out workaround for not resetting lucent cards more than once.  With
    these fixes, it appaers they are no longer necessary.
  o Set wi_gone when the card goes awol: typically when we get 0xffff back from
    the card.  Also, don't interact with a card that's gone, so we fail in
    seconds rather than minutes.  Also reduce amount of time we wait to .5s
    in wi_cmd.
  o clear wi_gone on ifconfig down to give some cards a chance after they wedge
    (this appears to unwedge one of my prism cards with old firmware).  ifconfig
    up will fail quickly enough if the card really is out to lunch.
  o Add delay in wi_init of 100ms.
  o wi_stop(ifp, 0->1) changes so that we clear sc_enabled so that we
    exit out of the interrupt routine by just acking the interrupt
  
  Submitted by: iedowse
  Approved by: re@ (scottl)
  
  # after the freeze I'll fix some of the minor style issues that reviewers
  # of this patch have told me about.
  
  Revision  Changes    Path
  1.158     +25 -10    src/sys/dev/wi/if_wi.c

: > The 'bad alloc' stuff was fixed a little while ago.
: 
: Yes, I thought so too.  I haven't seen any more commits of that nature
: since then.  Should I go to today's current?

Yes.  It should be much better.

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031211.184921.67799178.imp>