Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Mar 2013 11:18:59 +0000
From:      Max Brazhnikov <makc@freebsd.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Guido Falsi <madpilot@freebsd.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r313841 - head/comms/openobex
Message-ID:  <1886726.vG9fsaSg1C@mercury.ph.man.ac.uk>
In-Reply-To: <20130312014941.GC92762@FreeBSD.org>
References:  <201303102105.r2AL5C2o048218@svn.freebsd.org> <513E5682.1070704@FreeBSD.org> <20130312014941.GC92762@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 12 Mar 2013 01:49:41 +0000 Alexey Dokuchaev wrote:
> On Mon, Mar 11, 2013 at 11:11:14PM +0100, Guido Falsi wrote:
> > >>Would it be feasible to make DOXYGEN default for bulk pacakge building
> > >>cases but not for regular port users (that is, hide it behind BATCH or
> > >>PACKAGE_BUILDING)?
> > 
> > I do like your idea.
> > 
> > I have tested the port with the following stanza after OPTIONS_DEFINE:
> > 
> > .if !defined(BATCH) && !defined(PACKAGE_BUILDING)
> > OPTIONS_DEFAULT+=      DOXYGEN
> > .endif
> > 
> > It does work as expected, is this what you had in mind?
> 
> Yes, exactly.
> 
> > Should I check only against one of the two variables?
> 
> Not sure; better ask someone who's closer to package builder cluster? :)

Tinderbox sets both PACKAGE_BUILDING and BATCH, same does the pointyhat if I'm 
not mistaken. In this case the check for PACKAGE_BUILDING is enough.
But I'd really like to see port-wide implementation. I'm willing to make one, 
just need some time to finish new KDE ports.

Max



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1886726.vG9fsaSg1C>