Date: Sun, 09 Mar 2003 08:58:40 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Nate Lawson <nate@root.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha autoconf.c src/sys/cam cam_periph.h cam_xpt.c src/sys/cam/scsi scsi_da.c scsi_low.c scsi_ses.c src/sys/contrib/dev/fla fla.c src/sys/dev/aac aac.c aac_cam.c aac_debug.c aac_disk.c aac_pci.c aacvar.h ... Message-ID: <78338.1047196720@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 08 Mar 2003 23:46:43 PST." <Pine.BSF.4.21.0303082323370.90870-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.21.0303082323370.90870-100000@root.org>, Nate Lawson wri tes: >> On Saturday, Mar 8, 2003, at 03:01 US/Eastern, Poul-Henning Kamp wrote: >> >> > phk 2003/03/08 00:01:31 PST >> > >> > FreeBSD src repository >> > >> > Modified files: >> > sys/alpha/alpha autoconf.c >> > [...] >> > Log: >> > Centralize the devstat handling for all GEOM disk device drivers >> > in geom_disk.c. >> > >> > As a side effect this makes a lot of #include <sys/devicestat.h> >> > lines not needed and some biofinish() calls can be reduced to >> > biodone() again. > >In cam/scsi/scsi_da.c, please explain to me why you have removed all >checking of the DEVSTAT_BS_UNAVAILABLE flag as well as comments >explaining why this is useful. Because the blocksize is only relevant while the device is opened: no requests will happen while it is closed. All that logic was pointless. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?78338.1047196720>