Date: Thu, 26 Feb 2009 14:36:37 -0700 From: Scott Long <scottl@samsco.org> To: Alexander Motin <mav@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r189091 - head/sys/dev/ata Message-ID: <49A70B65.5090200@samsco.org> In-Reply-To: <200902262133.n1QLXnt3038889@svn.freebsd.org> References: <200902262133.n1QLXnt3038889@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Motin wrote: > Author: mav > Date: Thu Feb 26 21:33:48 2009 > New Revision: 189091 > URL: http://svn.freebsd.org/changeset/base/189091 > > Log: > Remove direct ata_completed() call options from ata_finish(), except for the > kernel dumping case. > > ata_completed() may initiate ata_reinit() on error, that may lead to drives > attach or detach. Attach and detach are sending requests to drives and sleep > waiting for results. But ata_finish() can be called directly from > interrupt handler where sleeping is prohibited, so we must break this chain > somewhere. This place seems to fit best. > Woo! Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49A70B65.5090200>