Date: Thu, 16 Sep 2010 20:10:38 -0700 From: Doug Barton <dougb@FreeBSD.org> To: "Carlos A. M. dos Santos" <unixmania@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Brian Somers <brian@freebsd.org>, Kirk McKusick <mckusick@freebsd.org> Subject: Re: svn commit: r212617 - head/sys/ufs/ffs Message-ID: <4C92DC2E.2020602@FreeBSD.org> In-Reply-To: <AANLkTikU6L8sjWi6cSWzK2wJqj7VAm5DSZ-YhQcZ49mP@mail.gmail.com> References: <201009141804.o8EI45kp088466@svn.freebsd.org> <20100916014404.0409017f@dev.lan.Awfulhak.org> <AANLkTikU6L8sjWi6cSWzK2wJqj7VAm5DSZ-YhQcZ49mP@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/16/2010 7:29 PM, Carlos A. M. dos Santos wrote: > On Thu, Sep 16, 2010 at 5:44 AM, Brian Somers<brian@freebsd.org> wrote: >> If INVARIANTS is not defined, the above i++ will not happen. > > Which does not cause any harm, since "i" is a local variable, not used > anywhere else in the function. A picky compiler would complain, > however, that the variable is never read. If 'i' is only ever used in the INVARIANTS case then it should be appropriately wrapped everywhere it appears. While the _current_ situation may be harmless, in the future lack of an appropriate indication of its use may cause a problem. This isn't just a pedantic concern, we had a case like this that broke the build just recently. Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C92DC2E.2020602>