Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Jul 1995 01:40:02 -0700
From:      burg@is.ge.com
To:        freebsd-bugs
Subject:   bin/591: ppp fails on Shiva LanRover
Message-ID:  <199507050840.BAA11841@freefall.cdrom.com>
In-Reply-To: Your message of Wed, 5 Jul 1995 10:35:49 %2B0200 <199507050835.KAA02076@burgpc.is.ge.com>

next in thread | previous in thread | raw e-mail | index | archive | help

>Number:         591
>Category:       bin
>Synopsis:       SPAP request REJexted in stead of NAKed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs (FreeBSD bugs mailing list)
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul  5 01:40:01 1995
>Originator:     Dick van den Burg
>Organization:
>Release:        FreeBSD 2.0.5-RELEASE i386
>Environment:
>Description:
When trying to connect with ppp to a Shiva Lanrover (version 3.2) the
authentication fails because the SPAP (Shiva Secure PAP) configuration
request the is sent by Shive is REJected by ppp in stead of NAKed.

Strictly speaking, Shive is also at fault, because the should not resend
the SPAP configuration request after a REJ. 

>How-To-Repeat:

Following is a log of the failing session:

07-04 21:09:08 [171] LCP: SendConfigReq
07-04 21:09:08 [171]  ACFCOMP
07-04 21:09:08 [171]  PROTOCOMP
07-04 21:09:08 [171]  ACCMAP [6] 00000000
07-04 21:09:08 [171]  MRU [4] 1500
07-04 21:09:08 [171]  MAGICNUM [6] 14a83a47
07-04 21:09:08 [171] LCP: state change Closed --> Req-Sent
07-04 21:09:11 [171] LCP: SendConfigReq
07-04 21:09:11 [171]  ACFCOMP
07-04 21:09:11 [171]  PROTOCOMP
07-04 21:09:11 [171]  ACCMAP [6] 00000000
07-04 21:09:11 [171]  MRU [4] 1500
07-04 21:09:11 [171]  MAGICNUM [6] 14a83a47
07-04 21:09:12 [171] LCP: Received Configure Request (2) state = Req-Sent (6)
07-04 21:09:12 [171]  MRU 1522
07-04 21:09:12 [171]  ACCMAP 000a0000
07-04 21:09:12 [171]  AUTHPROTO proto = c027
07-04 21:09:12 [171]  AUTHPROTO not implemented.
07-04 21:09:12 [171]  MAGICNUM 247467d0
07-04 21:09:12 [171]  ACFCOMP
07-04 21:09:12 [171] LCP:  SendConfigRej(Req-Sent)
07-04 21:09:12 [171]  AUTHPROTO proto = c027
07-04 21:09:12 [171] LCP: Received Configure Ack (2) state = Req-Sent (6)
07-04 21:09:12 [171] LCP: state change Req-Sent --> Ack-Rcvd
07-04 21:09:12 [171] LCP: Received Configure Request (3) state = Ack-Rcvd (7)
07-04 21:09:12 [171]  MRU 1522
07-04 21:09:12 [171]  ACCMAP 000a0000
07-04 21:09:12 [171]  AUTHPROTO proto = c027
07-04 21:09:12 [171]  AUTHPROTO not implemented.
07-04 21:09:12 [171]  MAGICNUM 247467d0
07-04 21:09:12 [171]  ACFCOMP
07-04 21:09:12 [171] LCP:  SendConfigRej(Ack-Rcvd)
07-04 21:09:12 [171]  AUTHPROTO proto = c027
07-04 21:09:12 [171] LCP: Received Configure Request (4) state = Ack-Rcvd (7)
07-04 21:09:12 [171]  MRU 1522
07-04 21:09:12 [171]  ACCMAP 000a0000
07-04 21:09:12 [171]  AUTHPROTO proto = c027
07-04 21:09:12 [171]  AUTHPROTO not implemented.
07-04 21:09:12 [171]  MAGICNUM 247467d0
07-04 21:09:12 [171]  ACFCOMP
07-04 21:09:12 [171] LCP:  SendConfigRej(Ack-Rcvd)
07-04 21:09:12 [171]  AUTHPROTO proto = c027

...... 20 more request /reject deleted

07-04 21:09:18 [171] LCP: Received Configure Request (24) state = Ack-Rcvd (7)
07-04 21:09:18 [171]  MRU 1522
07-04 21:09:18 [171]  ACCMAP 000a0000
07-04 21:09:18 [171]  AUTHPROTO proto = c027
07-04 21:09:18 [171]  AUTHPROTO not implemented.
07-04 21:09:18 [171]  MAGICNUM 247467d0
07-04 21:09:18 [171]  ACFCOMP
07-04 21:09:18 [171] LCP:  SendConfigRej(Ack-Rcvd)
07-04 21:09:18 [171]  AUTHPROTO proto = c027
07-04 21:09:18 [171] LCP: Received Configure Request (25) state = Ack-Rcvd (7)
07-04 21:09:18 [171]  MRU 1522
07-04 21:09:18 [171]  ACCMAP 000a0000
07-04 21:09:18 [171]  AUTHPROTO proto = c027
07-04 21:09:18 [171]  AUTHPROTO not implemented.
07-04 21:09:18 [171]  MAGICNUM 247467d0
07-04 21:09:18 [171]  ACFCOMP
07-04 21:09:18 [171] LCP:  SendConfigRej(Ack-Rcvd)
07-04 21:09:18 [171]  AUTHPROTO proto = c027
07-04 21:09:18 [171] LCP: Received Terminate Request (2) state = Ack-Rcvd (7)
07-04 21:09:18 [171] LCP: SendTerminateAck.
07-04 21:09:18 [171] LCP: state change Ack-Rcvd --> Req-Sent
07-04 21:10:27 [171] LCP: SendTerminateReq.
07-04 21:10:27 [171] LCP: state change Req-Sent --> Closing
07-04 21:10:27 [171] LCP: Received Configure Request (2) state = Closing (4)
## state = 4
07-04 21:10:27 [171] LCP: Received Terminate Ack (4) state = Closing (4)
07-04 21:10:27 [171] LCP: state change Closing --> Closed
07-04 21:10:27 [171] LCP: LayerFinish
07-04 21:10:27 [171] Phase: Dead
07-04 21:10:32 [171] PPP Terminated.

 

>Fix:
	

*** lcp.c.orig	Wed Jul  5 09:40:26 1995
--- lcp.c	Wed Jul  5 09:45:40 1995
***************
*** 517,525 ****
  	    goto reqreject;
  	  break;
  	default:
! 	  LogPrintf(LOG_LCP, " %s not implemented.\n", request);
! 	  goto reqreject;
! 	}
  	break;
        case MODE_NAK:
  	break;
--- 517,527 ----
  	    goto reqreject;
  	  break;
  	default:
! 	  LogPrintf(LOG_LCP, " %s not implemented, NAK.\n", request);
!           bcopy(cp, nakp, length);
!           nakp += length;
!           break;
!         }
  	break;
        case MODE_NAK:
  	break;

This is a trace after the patch has been applied


07-04 22:06:43 [1201] LCP: SendConfigReq
07-04 22:06:43 [1201]  ACFCOMP
07-04 22:06:43 [1201]  PROTOCOMP
07-04 22:06:43 [1201]  ACCMAP [6] 00000000
07-04 22:06:43 [1201]  MRU [4] 1500
07-04 22:06:43 [1201]  MAGICNUM [6] 10d2be1e
07-04 22:06:43 [1201] LCP: state change Closed --> Req-Sent
07-04 22:06:46 [1201] LCP: SendConfigReq
07-04 22:06:46 [1201]  ACFCOMP
07-04 22:06:46 [1201]  PROTOCOMP
07-04 22:06:46 [1201]  ACCMAP [6] 00000000
07-04 22:06:46 [1201]  MRU [4] 1500
07-04 22:06:46 [1201]  MAGICNUM [6] 10d2be1e
07-04 22:06:47 [1201] LCP: Received Configure Request (2) state = Req-Sent (6)
07-04 22:06:47 [1201]  MRU 1522
07-04 22:06:47 [1201]  ACCMAP 000a0000
07-04 22:06:47 [1201]  AUTHPROTO proto = c027
07-04 22:06:47 [1201]  AUTHPROTO not implemented, NAK.
07-04 22:06:47 [1201]  MAGICNUM 993c0be7
07-04 22:06:47 [1201]  ACFCOMP
07-04 22:06:47 [1201] LCP:  SendConfigNak(Req-Sent)
07-04 22:06:47 [1201]  AUTHPROTO proto = c027
07-04 22:06:47 [1201] LCP: Received Configure Ack (2) state = Req-Sent (6)
07-04 22:06:47 [1201] LCP: state change Req-Sent --> Ack-Rcvd
07-04 22:06:47 [1201] LCP: Received Configure Request (3) state = Ack-Rcvd (7)
07-04 22:06:47 [1201]  MRU 1522
07-04 22:06:47 [1201]  ACCMAP 000a0000
07-04 22:06:47 [1201]  AUTHPROTO proto = c123
07-04 22:06:47 [1201]  AUTHPROTO not implemented.
07-04 22:06:47 [1201]  MAGICNUM 993c0be7
07-04 22:06:47 [1201]  ACFCOMP
07-04 22:06:47 [1201] LCP:  SendConfigNak(Ack-Rcvd)
07-04 22:06:47 [1201]  AUTHPROTO proto = c123
07-04 22:06:47 [1201] LCP: Received Configure Request (4) state = Ack-Rcvd (7)
07-04 22:06:47 [1201]  MRU 1522
07-04 22:06:47 [1201]  ACCMAP 000a0000
07-04 22:06:47 [1201]  AUTHPROTO proto = c023
07-04 22:06:47 [1201]  MAGICNUM 993c0be7
07-04 22:06:47 [1201]  ACFCOMP
07-04 22:06:47 [1201] LCP:  SendConfigAck(Ack-Rcvd)
07-04 22:06:47 [1201]  MRU 1522
07-04 22:06:47 [1201]  ACCMAP 000a0000
07-04 22:06:47 [1201]  AUTHPROTO proto = c023
07-04 22:06:47 [1201]  MAGICNUM 993c0be7
07-04 22:06:47 [1201]  ACFCOMP
07-04 22:06:47 [1201] LCP: state change Ack-Rcvd --> Opend
07-04 22:06:47 [1201] LCP: LayerUp
07-04 22:06:47 [1201] Phase: Authenticate
07-04 22:06:47 [1201]  his = c023, mine = 0
07-04 22:06:47 [1201] PAP: yyyy (xxxx)
07-04 22:06:48 [1201] PapInput: ACK
07-04 22:06:48 [1201] Received PAP_ACK (Welcome)
07-04 22:06:48 [1201] Phase: Network
07-04 22:06:48 [1201] IPCP: state change Initial --> Closed
07-04 22:06:48 [1201] IPCP Up event!!
>Audit-Trail:
>Unformatted:





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507050840.BAA11841>