Date: Mon, 10 Feb 2014 11:12:44 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: David Chisnall <theraven@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, Steve Wills <swills@FreeBSD.org>, svn-ports-all@FreeBSD.org, John Marino <marino@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: svn commit: r343559 - head/net-p2p/litecoin Message-ID: <20140210101243.GX80056@ithaqua.etoilebsd.net> In-Reply-To: <E8F403F4-EA83-4F71-82E6-9BA27D8D217C@FreeBSD.org> References: <201402092329.s19NTHiq089517@svn.freebsd.org> <20140210011718.GA79272@mouf.net> <20140210075232.GU80056@ithaqua.etoilebsd.net> <E8F403F4-EA83-4F71-82E6-9BA27D8D217C@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0k4Rxg87Lb8yV0u3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 10, 2014 at 09:47:17AM +0000, David Chisnall wrote: > On 10 Feb 2014, at 07:52, Baptiste Daroussin <bapt@FreeBSD.org> wrote: >=20 > > I do not think that requires an approval, as for FreeBSD this change is= no-op, > > It is also no intrusive and just "fixes" building of that port for Drag= onfly. >=20 > Relying on OPSYS and OSVERSION is pretty horrible and doesn't scale. Alr= eady we have problems with convoluted OSVERSION expressions that are hard t= o understand and really mean 'fix for PR12345 has been merged to the releva= nt branch'. It would be far better to centralise these into a single file = for each platform, listing features / bugfixes / needed work-arounds and st= art removing explicit OSVERSION checks from any other Makefiles. If suppor= ting Dragonfly is one of our objectives, then I'd strongly encourage the pe= ople who are working on it to engage in this kind of cleanup, rather than p= iling more hacks into the tree. >=20 > David >=20 If one has a nice idea to centralize those informations I'm all about it, by nice idea I mean format and implementation. May that be OPSYS and/or OSVERSION both requires loading too many times bsd= =2E*.mk which is not good, looking forward for propositions. regards, Bapt --0k4Rxg87Lb8yV0u3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlL4phsACgkQ8kTtMUmk6EzMnACgu8yiX3vX+z8wwj0/+vVwK7dK yGAAnAxrLGsOhbdLjFb9JJSL4cpKQtfr =x4Qw -----END PGP SIGNATURE----- --0k4Rxg87Lb8yV0u3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140210101243.GX80056>