Date: Thu, 24 Dec 2009 01:07:41 GMT From: Ted Mittelstaedt <tedm@ipinc.net> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/141938: arj has some bit-rot Message-ID: <200912240107.nBO17fuu034398@www.freebsd.org> Resent-Message-ID: <200912240110.nBO1A5Zw089876@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 141938
>Category: misc
>Synopsis: arj has some bit-rot
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Dec 24 01:10:05 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Ted Mittelstaedt
>Release: 7.2
>Organization:
Internet Partners, Inc.
>Environment:
FreeBSD mail.madras.net 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May 1 08:49:13 UTC 2009 root@walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Building arj-3.10.22.tar.gz. in /usr/ports/archivers/arj spews several errors like:
TODAY v 1.22 [29/10/2000] Not a part of any binary package!
(this is repeated multiple times during the build)
fardata.c: In function 'vcprintf':
fardata.c:665: warning: 'short int' is promoted to 'int' when passed through '...'
fardata.c:665: warning: (so you should pass 'int' not 'short int' to 'va_arg')
fardata.c:665: note: if this code is reached, the program will abort
fardata.c:667: warning: 'short unsigned int' is promoted to 'int' when passed through '...'
fardata.c:667: note: if this code is reached, the program will abort
ARJDATA: unknown tag <@!_">
ARJDATA: unknown tag <@: display program option\np: match with Pathname !: execute command option\n">
>How-To-Repeat:
cd /usr/ports/archivers/arj
make
>Fix:
The following patch shuts off the worst complaint:
--- fardata.c.orig 2009-12-23 17:01:40.000000000 -0800
+++ fardata.c 2009-12-23 17:01:58.000000000 -0800
@@ -662,9 +662,9 @@
num=va_arg(args, int); /* num=va_arg(args, unsigned short);*/
#else
if(flags&SIGN)
- num=va_arg(args, short);
+ num=va_arg(args, int);
else
- num=va_arg(args, unsigned short);
+ num=va_arg(args, int);
#endif
}
else if(flags&SIGN)
mail#
but there's still plenty of compiler warnings and such that should be looked at, also that patch should be properly ifdef'ed
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912240107.nBO17fuu034398>