Date: Mon, 7 Jul 2008 12:52:09 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Ed Maste <emaste@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c Message-ID: <20080707195209.GD95574@elvis.mu.org> In-Reply-To: <200807032326.m63NQCdW044654@repoman.freebsd.org> References: <200807032326.m63NQCdW044654@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This really deserves a comment at each invocation of bcopy in order to prevent regressions by someone "fixing" it again. -Alfred * Ed Maste <emaste@FreeBSD.org> [080703 16:26] wrote: > emaste 2008-07-03 23:26:10 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_usrreq.c > Log: > SVN rev 180238 on 2008-07-03 23:26:10Z by emaste > > Use bcopy instead of strlcpy in uipc_bind and unp_connect, since > soun->sun_path isn't a null-terminated string. As UNIX(4) states, "the > terminating NUL is not part of the address." Since strlcpy has to return > "the total length of the string [it] tried to create," it walks off the end > of soun->sun_path looking for a \0. > > This reverts r105332. > > Reported by: Ryan Stone > > Revision Changes Path > 1.215 +4 -2 src/sys/kern/uipc_usrreq.c -- - Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080707195209.GD95574>