Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Jul 2002 06:16:07 -0700 (PDT)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 14990 for review
Message-ID:  <200207271316.g6RDG7AI054131@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14990

Change 14990 by rwatson@rwatson_tislabs on 2002/07/27 06:15:43

	Note that we need a seperate entry point for the F_SETFL fcntl,
	since we really want to authorize the delta not just the flags.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/kern_descrip.c#18 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_descrip.c#18 (text+ko) ====

@@ -326,6 +326,11 @@
 				mode |= VAPPEND;
 			vn_lock((struct vnode *)fp->f_data, LK_EXCLUSIVE |
 			    LK_RETRY, td);
+			/*
+			 * XXX: A seperate entry point should be used here
+			 * to pass in both the old and the new flags,
+			 * with authorization performed only on the delta.
+			 */
 			error = mac_cred_check_open_vnode(td->td_ucred,
 			    (struct vnode *)fp->f_data, mode);
 			VOP_UNLOCK((struct vnode *)fp->f_data, 0, td);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207271316.g6RDG7AI054131>