Date: Mon, 24 Nov 2014 14:48:40 +0400 From: "Alexander V. Chernikov" <melifaro@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274921 - projects/routing/sys/net Message-ID: <54730D08.3070201@FreeBSD.org> In-Reply-To: <20141124065122.GE47144@FreeBSD.org> References: <201411231747.sANHlC9Y088840@svn.freebsd.org> <20141124065122.GE47144@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24.11.2014 10:51, Gleb Smirnoff wrote: > On Sun, Nov 23, 2014 at 05:47:12PM +0000, Alexander V. Chernikov wrote: > A> Author: melifaro > A> Date: Sun Nov 23 17:47:12 2014 > A> New Revision: 274921 > A> URL: https://svnweb.freebsd.org/changeset/base/274921 > A> > A> Log: > A> Finish r274335#2: put RT_LOCK_DESTROY() back. > A> > A> Modified: > A> projects/routing/sys/net/route.c > A> > A> Modified: projects/routing/sys/net/route.c > A> ============================================================================== > A> --- projects/routing/sys/net/route.c Sun Nov 23 17:45:49 2014 (r274920) > A> +++ projects/routing/sys/net/route.c Sun Nov 23 17:47:12 2014 (r274921) > A> @@ -1505,6 +1505,7 @@ rtrequest1_fib(int req, struct rt_addrin > A> if (rn == NULL) { > A> ifa_free(rt->rt_ifa); > A> Free(rt_key(rt)); > A> + RT_LOCK_DESTROY(rt); > A> uma_zfree(V_rtzone, rt); > A> #ifdef FLOWTABLE > A> if (rt0 != NULL) > > Don't know about your branch, but in head RT_LOCK_DESTROY is done > in V_rtzone finit method. So you are going to hit destroying of Well, since there is no place to do rte accounting, I reverted r262763, so there is no init/fini UMA methods. > already destroyed mutex. > > btw, I see no good reason for virtualizing the zone. (Yep, I did that.) :) >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54730D08.3070201>