Date: Tue, 25 Nov 2014 11:18:51 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Ermal LuXXi <eri@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274709 - head/sys/netpfil/pf Message-ID: <86ppcbvb04.fsf@nine.des.no> In-Reply-To: <86tx1nvcy4.fsf@nine.des.no> ("Dag-Erling =?utf-8?Q?Sm=C3=B8r?= =?utf-8?Q?grav=22's?= message of "Tue, 25 Nov 2014 10:36:51 %2B0100") References: <201411191331.sAJDV9bH092190@svn.freebsd.org> <86tx1nvcy4.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > This is wrong, and causes a panic with some network adapters (vtnet, for > one). It is closely related to 192013 and should not have been > committed without consulting me first. Please revert, or just #if 0 out > the entire block since the old code is even more wrong than your > version. Note: I am aware that the patch in 192013 is incorrect as well, which is why I never committed it, although I should have noted that in the PR. The current IPv4 code is also slightly wrong, but not as much as the IPv6 code. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ppcbvb04.fsf>