Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Mar 2014 02:24:29 +0000 (UTC)
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r263960 - stable/10/sys/security/audit
Message-ID:  <201403310224.s2V2OT2S023167@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjg
Date: Mon Mar 31 02:24:29 2014
New Revision: 263960
URL: http://svnweb.freebsd.org/changeset/base/263960

Log:
  MFC r263458:
  audit: plug FILEDESC_LOCK leak in audit_canon_path.

Modified:
  stable/10/sys/security/audit/audit_bsm_klib.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/security/audit/audit_bsm_klib.c
==============================================================================
--- stable/10/sys/security/audit/audit_bsm_klib.c	Mon Mar 31 02:19:57 2014	(r263959)
+++ stable/10/sys/security/audit/audit_bsm_klib.c	Mon Mar 31 02:24:29 2014	(r263960)
@@ -497,6 +497,7 @@ audit_canon_path(struct thread *td, int 
 			/* XXX: fgetvp() that vhold()s vnode instead of vref()ing it would be better */
 			error = fgetvp(td, dirfd, NULL, &cvnp);
 			if (error) {
+				FILEDESC_SUNLOCK(fdp);
 				cpath[0] = '\0';
 				if (rvnp != NULL)
 					vdrop(rvnp);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403310224.s2V2OT2S023167>