Date: Thu, 14 Nov 2013 09:28:55 GMT From: Horia Racoviceanu <horia@racoviceanu.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/183950: audio/audacity build fails with TWOLAME=off [PATCH] Message-ID: <201311140928.rAE9St8N008676@oldred.freebsd.org> Resent-Message-ID: <201311140930.rAE9U1Op064214@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 183950
>Category: ports
>Synopsis: audio/audacity build fails with TWOLAME=off [PATCH]
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Nov 14 09:30:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Horia Racoviceanu
>Release: FreeBSD 9.1-RELEASE amd64
>Organization:
>Environment:
FreeBSD horia.lan 9.1-RELEASE-p7 FreeBSD 9.1-RELEASE-p7 #0: Mon Sep 9 21:34:37 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
audacity has a mandatory depend on libsndfile, which is implicitly handled by option TWOLAME (audio/twolame->audio/libsndfile). With TWOLAME=off, libsndfile doesn't get installed and build fails.
checking for SNDFILE... no
configure: Libsndfile libraries are NOT available as system libraries
checking for ./lib-src/libsndfile/src/sndfile.h.in... no
configure: libsndfile libraries are NOT available in this source tree
configure: disabling LIBSNDFILE
configure: error: Audacity requires libsndfile to be enabled
the LIB_DEPENDS on libsndfile seems to have been accidentally removed by an automatic option-ifier script in r311611.
>How-To-Repeat:
>Fix:
- Add libsndfile.so to LIB_DEPENDS
- Remove SNDFILE_LIB_DEPENDS
- Remove SNDFILE_CONFIGURE_WITH
Patch attached with submission follows:
Index: audio/audacity/Makefile
===================================================================
--- audio/audacity/Makefile (revision 332840)
+++ audio/audacity/Makefile (working copy)
@@ -13,6 +13,8 @@
LICENSE= GPLv2
+LIB_DEPENDS= libsndfile.so:${PORTSDIR}/audio/libsndfile
+
WRKSRC= ${WRKDIR}/${PORTNAME}-src-${PORTVERSION}
USE_AUTOTOOLS= aclocal autoconf
@@ -66,9 +68,6 @@
DEBUG_CONFIGURE_WITH= debug
-SNDFILE_CONFIGURE_WITH= libsndfile
-SNDFILE_LIB_DEPENDS= libsndfile.so:${PORTSDIR}/audio/libsndfile
-
FFMPEG_CONFIGURE_WITH= ffmpeg
FFMPEG_RUN_DEPENDS= ffmpeg0:${PORTSDIR}/multimedia/ffmpeg0
FFMPEG_BUILD_DEPENDS= ffmpeg0>=0:${PORTSDIR}/multimedia/ffmpeg0
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311140928.rAE9St8N008676>