Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Feb 2014 11:34:27 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r262553 - head/sys/dev/mps
Message-ID:  <201402271134.s1RBYRu8014285@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Thu Feb 27 11:34:26 2014
New Revision: 262553
URL: http://svnweb.freebsd.org/changeset/base/262553

Log:
  Pass proper pointer to bus_dmamem_free() in mps_iocfacts_free().
  
  Passing there pointer into the middle of allocated area caused kernel
  panic during reinit, for example, after firmware upgrade.
  
  MFC after:	1 week

Modified:
  head/sys/dev/mps/mps.c

Modified: head/sys/dev/mps/mps.c
==============================================================================
--- head/sys/dev/mps/mps.c	Thu Feb 27 09:59:15 2014	(r262552)
+++ head/sys/dev/mps/mps.c	Thu Feb 27 11:34:26 2014	(r262553)
@@ -617,8 +617,8 @@ mps_iocfacts_free(struct mps_softc *sc)
 
 	if (sc->post_busaddr != 0)
 		bus_dmamap_unload(sc->queues_dmat, sc->queues_map);
-	if (sc->post_queue != NULL)
-		bus_dmamem_free(sc->queues_dmat, sc->post_queue,
+	if (sc->free_queue != NULL)
+		bus_dmamem_free(sc->queues_dmat, sc->free_queue,
 		    sc->queues_map);
 	if (sc->queues_dmat != NULL)
 		bus_dma_tag_destroy(sc->queues_dmat);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402271134.s1RBYRu8014285>