Date: Wed, 28 Feb 2007 03:30:55 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: phk@phk.freebsd.dk Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/usb umass.c Message-ID: <20070228.033055.-135505832.imp@bsdimp.com> In-Reply-To: <43468.1172657639@critter.freebsd.dk> References: <20070228.031000.1649769988.imp@bsdimp.com> <43468.1172657639@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <43468.1172657639@critter.freebsd.dk>
"Poul-Henning Kamp" <phk@phk.freebsd.dk> writes:
: In message <20070228.031000.1649769988.imp@bsdimp.com>, "M. Warner Losh" writes
: :
:
: >: > Create a new quirk READ_CAPACITY_OFFBY1
: >:
: >: A better idea would be to have scsi_da.c try to read the
: >: last sector and chop it if it fails.
: >
: >Why is that a better idea?
:
: Because it will work automatically and not rely on us preventively
: adding the bogus devices to the kernel.
:
: Trivially testable quicks shouldn't have to be compiled into
: static lists.
Others have observed that the number of sectors on a disk should be
even. Therefore if maxsectors returned is even, it implies an odd
number of sectors and should be adjusted. That might be an even
easier path to follow... I'm never sure when one can schedule
additional I/O inside of cam...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070228.033055.-135505832.imp>