Date: Sat, 17 May 2014 02:50:01 GMT From: dfilter@FreeBSD.ORG (dfilter service) To: freebsd-amd64@FreeBSD.org Subject: Re: amd64/189668: commit references a PR Message-ID: <201405170250.s4H2o11b022507@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR amd64/189668; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: amd64/189668: commit references a PR Date: Sat, 17 May 2014 02:45:07 +0000 (UTC) Author: jhb Date: Sat May 17 02:45:04 2014 New Revision: 266281 URL: http://svnweb.freebsd.org/changeset/base/266281 Log: Clear the data buffer length field when freeing a command structure so that it doesn't leak through when the command structure is reused for a user command without a data buffer. PR: amd64/189668 Tested by: Pete Long <pete@nrth.org> MFC after: 1 week Modified: head/sys/dev/aac/aac.c Modified: head/sys/dev/aac/aac.c ============================================================================== --- head/sys/dev/aac/aac.c Sat May 17 02:39:20 2014 (r266280) +++ head/sys/dev/aac/aac.c Sat May 17 02:45:04 2014 (r266281) @@ -1408,6 +1408,7 @@ aac_release_command(struct aac_command * fwprintf(sc, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, ""); /* (re)initialize the command/FIB */ + cm->cm_datalen = 0; cm->cm_sgtable = NULL; cm->cm_flags = 0; cm->cm_complete = NULL; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405170250.s4H2o11b022507>